Optionwidgets onoff do not save or display properly [#149103]

With text fields that use the optionwidget of type 'onoff', there are currently two critical problems:

values currently do not get saved at all after submitting a node add/edit form
the label of the field doesn't get displayed on the node add/edit form

AFAICT, the cause of (1) is that the '#return_value' is not getting set to '1' (it's getting set to nothing) in the form definition for the widget, and that the submitted value is getting unnecessarily converted to an array. The cause of (2) is that the field's label is not getting assigned to '#title'.

Attached patch fixes these issues. Please review and commit if OK.

Comment	File	Size	Author
#1	optionwidgets_fix_onoff_save_0.patch	1.09 KB	Jaza
	optionwidgets_fix_onoff_save.patch	1.14 KB	Jaza

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Jaza CreditAttribution: Jaza commented 4 June 2007 at 06:26

File	Size
optionwidgets_fix_onoff_save_0.patch	1.09 KB

Oops - bad file paths in that patch. New patch attached.

Comment #2

Jaza CreditAttribution: Jaza commented 4 June 2007 at 06:55

Assigned:

Jaza

» Unassigned

Comment #3

z.stolar CreditAttribution: z.stolar commented 26 June 2007 at 19:23

Confirmed. The patch has resolved the problem in my case.
One issue remains: I had to have a format of:
key|label
in the options area (e.g., I couldn't have just 'label')

Comment #4

ray007 CreditAttribution: ray007 commented 8 July 2007 at 15:14

I can confirm that this patches fixes my problems with on-off checkboxes not getting saved correctly too. Patch should be applied to mainline if it doesn't cause any other problems.

Comment #5

ray007 CreditAttribution: ray007 commented 15 July 2007 at 19:53

Seems I was a bit too optimistic, I'm again having troubles with the on-off checkbox.
Will use 2 radio buttons until this issue is resolved.

Comment #6

dgtlmoon CreditAttribution: dgtlmoon commented 16 July 2007 at 00:58

I believe there are three issues at play here

- hook_widget for 'options_onoff' is not ensuring it only looks at the first set of key|value specified

Use the 'each' function to ensure we get the first (0) set of key|value's from the array not $vals[1]

         case 'options_onoff':
           // Display only the 'On' value of $options;
-          $vals = array_keys($options);
-          $on_value = $vals[1];
+          list($key, $val) = each($options);
+          $on_value = $val;
           $form[$field['field_name']]['keys'] = array(
             '#type' => 'checkbox',

- title field not wrapped in t() and not referencing the option value by key

-            '#title' => $options[$on_value],
+            '#title' => t($options[$key]),

- hook_widget for 'options_onoff' has nothing to check to see if it should be enabled by default or not

'#default_value' => $items['default keys'][0],

"$items['default keys'][0]" seems to always be set ?

this should be fixable, except for what to reference the default value as?

Comment #7

dgtlmoon CreditAttribution: dgtlmoon commented 16 July 2007 at 01:54

Status:

Needs review

» Postponed (maintainer needs more info)

dropping this back to active as there are still issues with figuring out what the default value should be referenced from ?

However, I'm using the editable fields module, and it has the "unchecked boxes don't get submitted with the form" problem... http://drupal.org/node/236898

I'm trying to figure out how to fix it and wonder is the fix made to CCK might help me?
thanks.