Download & Extend

Redundant indexes on Styles and Layers tables

Project:OpenLayers
Version:7.x-3.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Just saw this in phpMyAdmin and figured it would be worth mentioning.

Problems with indexes of table `openlayers_layers`
Problems with indexes of table `openlayers_styles`

Comments

#1

Title:The indexes PRIMARY and name seem to be equal and one of them could possibly be removed.» Redundant indexes on Styles and Layers tables
Version:7.x-3.x-dev» 7.x-2.x-dev
Category:bug report» task

Thanks, @mgifford. This is redundant. But it will need an update function to go with it, so not making it a priority at the moment.

#2

Yup.. Just as a todo for the next release point or something. It might have a small performance impact, but other than that.

#3

Status:active» needs review

Small patch to do this.

AttachmentSizeStatusTest resultOperations
1491314-03-openlayers.dropdupindex.patch983 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 238 pass(es).View details

#4

Version:7.x-2.x-dev» 7.x-3.x-dev

Looks good. I just did a fresh install from the git repo 7.x-3.x and it worked. I reworked this patch so it can be applied with git rather than patch.

AttachmentSizeStatusTest resultOperations
1491314-04-openlayers.dropdupindex.patch1.02 KBIdlePASSED: [[SimpleTest]]: [MySQL] 236 pass(es).View details

#5

Status:needs review» fixed

Thanks @ekes & @mgifford, committed to 7.x-2.x & 7.x-3.x ;-)

#6

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here