testHavingCountQuery() fails on pgsql and sqlite

database-test-having-1.patch queued for re-testing.

retested, it has passed :)

Im facing the same problem at other issue. we can't / do not test on pgsql and sqlite on d.org bots, right ?

What I believe is that someone needs to setup simple test on their local environment, and run it against Drupal core with this patch, while D8 is installed on pgsql and sqlite. I would be happy to do this if no one else wants to.

I ran the database tests before and after applying this patch on all three of the database servers mentioned. Before the patch was applied SQLite and PostgreSQL both passed the exception noted by idaniellau. After the patch was applied non of the three passed the exception. So, it appears that the patch fixed the problem.

droplet is right, we have no pgsql or sqlite test bots, and since not many people run tests themselves with either database either, they're broken most of the time. Thanks hosef for doing the testing on this.

Committed/pushed to 8.x, moving back to 7.x for backport. Should be a straightforward backport so marking Novice for the re-roll.

Taking this for backporting to D7.

Backport to D7.

Starting up my VMs. :P

EDIT:
I think I broke VirtualBox when I ran apt-get upgrade this morning, so I will be back later when I fix it.

Ok, I got everything working again and ran all of the tests again. D7 results are the same as the results in D8 so I believe this is done and ready to be committed.

I did have some other tests fail in my D7 Postgresql test run, but they appeared to be unrelated to this issue and they did not occur in my D8 tests. Therefore, my assumption is that they have already been fixed by some other patch.

Great, thanks for the fix + testing on this folks!

committed and pushed to 7.x.