If a user doesn't have the "change layouts in place editing" permission, the "Customize this page" button shows up twice. The second instance of the button blows up quite nicely when clicked.

Simple enough fix from what I can tell.

CommentFileSizeAuthor
#1 panels-change-page-layouts-perm-1491600-1.patch774 bytestwistor

Comments

twistor’s picture

twistor commented
Status: Active » Needs review
StatusFileSize
new panels-change-page-layouts-perm-1491600-1.patch774 bytes

Makes sense to me.

twistor’s picture

twistor commented

Thoughts:

  1. Would it make more sense to reuse the "administer panels layouts" permission?
  2. Should the PIE permissions be moved to panels_ipe.module?
merlinofchaos’s picture

merlinofchaos commented

1) Maybe though IPE is its own thing and it represents that in the future, each IPE will have a setting for that.
2) The IPE perms are temporary anyway, and originally we were expecting to have multiple IPE modules.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Committed and pushed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 5a39eb1 on 7.x-3.x, 7.x-3.x-i18n, 8.x-3.x by merlinofchaos: 
    Issue #1491600: Extra (and broken) "Customize this page" button in IPE...