Separate issue by @dejabobbi on #1441396: Half-life notification emails continue every notification run: "I've been getting this error: "user notice: The classified_notifications_mail() function called token replacement with an array rather than a string for $text in /home/toymania/public_html/modules/token/token.module on line 263."

And then the emails sent out don't have the ad/url populated into them, just the spaceholder text. Is there something obvious I am missing on that?"

CommentFileSizeAuthor
#1 0001-Issue-1491880-incorrect-use-of-token_replace_multipl.patch2.78 KBfgm

Comments

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Active » Needs work
StatusFileSize
new 0001-Issue-1491880-incorrect-use-of-token_replace_multipl.patch2.78 KB

OK, here is test catching the error.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Title: Incorrect use of token_replace_multiple in classified_notifications_mail() » Incorrect token generation and use for classified

Digging into it, the logic backported from D7 just does not work as such. Adding new tests.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs work » Fixed

Lots of fixes in today's dev version.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Fixed » Patch (to be ported)

Port needed to D7 for test (at least).

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Patch (to be ported) » Fixed

Test ported to D7. Existing implementation passed it without change.

Seijun’s picture

Seijun commented

Using the D6 version, I have a similar issue. Tokens in notification emails only show space-holder text:
"Please visit your ads list at [classified-ads-url] if you wish to modify them. [ads]"

No errors are reported though. Should I start a new issue for this?

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Fixed » Active

This looks like the same issue, except it is supposed to have been fixed since #3. Are you using 6.x-3.0 ?

Seijun’s picture

Seijun commented

I'm using 3.0-rc2.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Version: 7.x-3.x-dev » 6.x-3.0-rc2
Status: Active » Postponed (maintainer needs more info)

You should now use 6.x-3.0: this issue is supposed to have been fixed between RC2 and final. Can you confirm ?

Seijun’s picture

Seijun commented

I will confirm in a few days when I get another notification.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented

Just make sure you are on 3.0, not 3.0rc2, then.

Seijun’s picture

Seijun commented

Changing to 3.0 fixed it, thank you!

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Postponed (maintainer needs more info) » Fixed

Good !

dejabobbi’s picture

dejabobbi commented

I've been meaning to come back in and thank you for this fix! (Well, this one and the half-life thing!!) It is most appreciated. :-)

We're no longer seeing the errors and haven't gotten any complaints/reports from our users, so everything seems to be fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.