Closed (fixed)
Project:
Views Slideshow JCarousel
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Mar 2012 at 06:48 UTC
Updated:
23 Sep 2014 at 01:21 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
inteja commentedAnyone got any ideas about this? Sorry, I'm a bit desperate ...
Comment #2
simon georges commented@inteja, did you try my patch in #1450846: jCarousel is never initialized properly with Omega theme? I have encountered several javascript issues with the current state of the module.
Comment #3
inteja commentedThanks for the reply. I tried the patch but it did not work for me sorry.
Firstly, the skin became messed up (reverted to a simple unordered list, without nav arrows).
Secondly, the views pager functionality stopped working altogether.
The unpatched code worked better, apart from:
1 is critical for me. I am searching around for other options (as I'm running out of time on this project) but I haven't found anything else yet that offers a jcarousel thumbnail pager with tight views slideshow integration.
Any additional help you could provide would be most appreciated!
Comment #4
garald4 commentedI'm running into the same problem. It looks like the class views_slideshow_active_pager_field_item gets stuck on the first item in the pager and is not being removed and rewritten to the next active pager item. This pager widget is a great module, specially with its ease of use with Views Slideshow, but I really need to be able to style the active pager item. I'm not a Javascript guy but have been trying to backwards engineer the views_slideshow_jcarousel.theme.inc file to fix the function _views_slideshow_jcarousel_preprocess_pager_item with no luck so far. Anyone else with thoughts or ideas on getting the active class to change with the currently active pager item?
Comment #5
renenee commentedAnyone make headway on this one? I'm experiencing the same issue as #4.
Comment #6
renenee commentedFound a solution for #4. If you go into the settings for your Slideshow in Views, under "jQuery Cycle Custom Options" select "pager" and input ul.jcarousel-list (no quotes or apostrophes) or whatever the selector is for your pager. This activated the activeSlide class for the active list item in the pager.
Comment #7
julianmancera commentedHi rmd-14,
I can't find how did you do that, should I download the json and that stuff to activate the custom options? At the bottom when a select pager there is not input field to put that selector.
Regards,
Julian Mancera
Comment #8
jwilson3Besides #1450846: jCarousel is never initialized properly with Omega theme, there are a couple other significant errors in the
views_slideshow_jcarousel.jsfile, including the missing active class on this issue.The third issue is that somehow a section of the code has been duplicated.
Here's a patch that a) removes the duplicate code, and b) fixes the active class issue.
Comment #9
bayousoft commented@jwilson3 I am unable to apply this patch
Comment #10
bayousoft commented#6 does add an activeslide class to the li in my case
Comment #11
kristen polUpdate: #6 DID work for me. (I hadn't clicked the "update" link previously.) I was able to apply a style like:
to see that it was working.
I tried the patch from #8 and it didn't solve the active pager issue for me. Note that you have to edit the patch directory structure to apply to your own site unless you are using the exact directory structure in the patch:
www/sites/all/modules/contrib/views_slideshow_jcarousel/if you are applying the patch from within the:
views_slideshow_jcarouseldirectory then you can delete all occurrences of:
www/sites/all/modules/contrib/views_slideshow_jcarousel/from the patch file and then apply with:
patch -p1 < [patchfile]Comment #12
zeropx commented#6 worked great for me. Thanks!
Comment #13
d.sibaud commentedI did confirm that both approaches (#6 and #8) work, but the patch in comment #8 made by jwilson3 solves also issues related to the multiple triggering of duplicated funcions in the js, maybe the patch can be better rerolled, but for now it's enough.
thanks jwilson3
Comment #14
jamsilver commentedJust rerolling #8 to conform with drupal patching guidelines. This can now be applied with patch -p1 < [patchfile] directly.
Comment #15
skylord commentedWorks OK, thanks. Applied without problem and active item is now highlighted.
Comment #16
jomarocas commentedpatch #14 works for me
Comment #19
netw3rker commentedThanks for catching this duplicated code, and adding an active class! I've committed this patch. Its always nice to see a negative lines of code fix :) keep it up!