Hi,

field_remove_item is a highly needed module, thank you for bringing it in.
I rewrote the module using a different implementation, following core behavior closer and field_collection approach, which seems really solid.

Would be great to see this committed and released as a real project !

CommentFileSizeAuthor
field_remove_item_clean_implementation.patch10.97 KBjide

Comments

FranciscoLuz’s picture

FranciscoLuz commented
Status: Closed (won't fix) » Needs review

@jide

Sorry for taking so long to respond. I forgot to subscribe to the issues so just noticed your post right now.

Thank you very much putting some effort in to improve the code. I am gonna check out your patch.

Cheers,

Francisco Luz
www.nortaox.com

jide’s picture

jide commented

Great. I already noticed some bugs, I'll post an updated patch soon, but the general logic is here.

FranciscoLuz’s picture

FranciscoLuz commented

@jide

You definitely has deeper understanding of the field API and its process then I do. I actually learned a few things by looking into your code but still gotta get my head around in some points.

As you mentioned it's not quite working, so I've just created a new branch called jide in which I have applied your patch. Once we fix the issues this new implementation has than we merge it back into the 7.x-1.x branch.

The current 7.x-1.x branch has some jerry-built code but for the time being it is doing its job.

I don't have permission to publish full projects on drupal.org so I have just added you as a co-maintainer of this project. Apparently you do have permission to publish full projects so would you be interested in publishing this module under your account credentials?

Cheers,

Francisco Luz

FranciscoLuz’s picture

FranciscoLuz commented
Status: Needs review » Closed (won't fix)

This patch no longer applies. The module has been re-written.

Status: Needs review » Closed (won't fix)

Correcting issue status, see #2125263: Issue status not taken from last comment during D7 migration.