Within the Drupal 8's page.tpl.php, the site slogan should use an h2 instead of a paragraph tag when rendered. I have included code which makes the presentation more semantic, but I am sure the logic could be simplified some. I have included a patch and the following code modifies the existing block of code which handles slogan/site name.
<?php if ($site_name || $site_slogan): ?>
<?php if ($title && $site_name && $site_slogan): ?>
<div id="site-name"><strong>
<a href="<?php print $front_page; ?>" title="<?php print t('Home'); ?>" rel="home"><?php print $site_name; ?></a>
</strong></div>
<div id="site-slogan"><?php print $site_slogan; ?></div>
<?php elseif($title && $site_name): /* Use div when the content title is not empty and site name exists */ ?>
<div id="site-name"><strong>
<a href="<?php print $front_page; ?>" title="<?php print t('Home'); ?>" rel="home"><?php print $site_name; ?></a>
</strong></div>
<?php elseif($title && $site_slogan): /* Use div when the content title is not empty and slogan exists */ ?>
<div id="site-slogan"><?php print $site_slogan; ?></div>
<?php elseif($site_slogan && $site_name): /* Use hgroup when the content title is empty and slogan and site name exists */ ?>
<hgroup>
<h1 id="site-name">
<a href="<?php print $front_page; ?>" title="<?php print t('Home'); ?>" rel="home"><?php print $site_name; ?></a>
</h1>
<h2 id="site-slogan"><?php print $site_slogan; ?></h2>
</hgroup>
<?php elseif($site_slogan): /* Use h2 when the content title is empty and slogan exists */ ?>
<h2 id="site-slogan"><?php print $site_slogan; ?></h2>
<?php endif; ?>
<?php endif; ?>| Comment | File | Size | Author |
|---|---|---|---|
| #2 | sitetitle-slogan-hgroup-1492638.patch | 2.24 KB | tlattimore |
| #1 | system-semantic slogan-1492638-2.patch | 2.16 KB | ron williams |
| semantic-slogan-page.tpl_.php_.patch | 1.66 KB | ron williams |
Comments
Comment #1
ron williams commentedCorrect patch.
Comment #2
tlattimore commentedI also have thought the the putting the site slogan inside a paragraph was incorrect.
The patch in comment #1 doesn't look like it was done using the standard
git diffformat for creating patches(see http://drupal.org/node/707484), it also had some excessive spaces at the end of a couple lines. I have resolved this and re-rolled the patch.Comment #4
droplet commentedBased on the reason why don't use it #1077578: [Followup] Convert bartiks page.tpl.php to HTML5. It's too early to reintroduce it into core.
Comment #5
ron williams commentedCan you provide some additional details on the issue with implementing these tags? I did not see further reasons except notices regarding changes in core. A link to the comment where the issue is raised with the commit?
Comment #6
David_Rothstein commentedI think it's in reference to this comment - #1077578-13: [Followup] Convert bartiks page.tpl.php to HTML5? ... which suggests that
<hgroup>might be removed from HTML5. I haven't followed all the recent HTML5 politics around this but I guess the idea is we should make sure the tag is staying before we start adding it to Drupal 8?In any case, I took a quick look at the patch itself, and it looks good but it does seem like some of the logic could probably be simplified. For example:
I don't think we need the same if() statement (at the top and bottom) repeated twice?
I also saw a couple small code style issues - for example, a double space should be used to indent (rather than a tab).
Comment #7
David_Rothstein commentedMoving to "needs work" for now, since there is a patch.
Comment #8
lauriiiComment #10
davidhernandezMoving this to Stable. We may be able to make this change in core now, but will need BC. It probably can't be changed at all in Classy.
Comment #11
joginderpcI had tested the patch but on same path the file does not exist now.
Comment #22
quietone commentedThanks for making this issue and for working on a patch. The file page.tbl.php is no longer in core and the Stable theme has been removed from core. I think it is time to close this as outdated.