this makes no real sense...

#: update_status.info:0
msgid "1180743261"
msgstr ""
CommentFileSizeAuthor
#1 potx_inc.patch614 byteshass

Comments

hass’s picture

hass commented
Status: Active » Needs review
StatusFileSize
new potx_inc.patch614 bytes

here is a patch for this bug.

Aside what about "project"? shouldn't we unset this, too?

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

Is datestamp a valid key for the .info files? We might be better off with defining a whitelist of strings to use as the .info file keys proliferate in Drupal 6.
Project is displayed on the module grouping fieldsets on the modules page, so they are subject of translation.

hass’s picture

hass commented

yes, "datestamp" is a new valid key. It will be added for "update_status" module by build system since... mid April / May?

hass’s picture

hass commented

i learned about another allowed key named "update status url"... we should definitively create a white list! this is much easier to maintain

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

OK, can you help collect a whitelist? The most obvious ones are: 'name', 'description' and 'package'. Are there any other keys used, which should be translatable?

hass’s picture

hass commented

Your list sounds ok, but i'm not sure about "package"...

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Fixed

Package names are displayed with t(), see line 1837 of system.module (Drupal 6.x-dev). I committed a simple whitelist with these three values. Let me know if you have any other issues with potx, I hope we rectified all problems you encountered so far. Thanks for your rigorous reviews and fix suggestions!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)