Closed (fixed)
Project:
Webform Entity
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Mar 2012 at 22:10 UTC
Updated:
18 Apr 2012 at 21:11 UTC
At line 648 of webform_entity.module, there's a check to see if we're currently on the node page for the webform node. However, this prevents these fields from rendering when displaying the webform as a block with no additional fields, because webform_node_view() in webform.module checks if $node->webform['components'] is empty.
I can't think of a case where the nid check is necessary, because wouldn't all cases be caught by the node type and field instance count checks? Even if there was another node on the page that had no components, wouldn't we want to add the fake field anyway?
Comments
Comment #1
tizzo commentedThis is a thornier issue than it looks like because if empty components are inserted on pages where they don't belong, things blow up in webform. Looking into a solution with jody lynn...
Comment #2
jody lynnI can't recall why I had to add that check, so I took it out from the multistep branch and we will find out soon why it was there if it was still important :) If that happens them we'll have a better idea of our new parameters for the problem.