remove unecessary *heavy* query [#149339]

Duplicate checking for nodes / comments has come and gone and hopefully it'll come back soon for D6.

All along though, there has been an expensive query that lives deep within comment.module offering no real intrinsic value and slowing down sites everywhere.

This patch removes this query that adds a warning to watchdog about a duplicate comment.

This warning offers no real value and a patch that addresses duplicates at the form level would do a much better job. This is just a first, easy step.

Here's a more detailed look at the performance implications of that query: http://drupal.org/node/134139

Comment	File	Size	Author
#1	ts_10.patch	1.32 KB	m3avrck

Comments

Status	File	Size
new	ts_10.patch	1.32 KB

Comment #2

catch

he/him

English

commented 4 June 2007 at 22:37

I see no reason to have a watchdog notice about duplicate comments if duplicates can be avoided via other methods. I must have had dozens of duplicate comments on my site, and never noticed the error in the watchdog amongst everything else that goes in it.

The patch is very simple, simply removing this query from the module altogether.

So +1.