Compound filter does not work correctly on NULL columns

When we developed this filter we said: Let's make sure it works for most cases, because for example certain handlers will work a bit different internally.

So what we actually want on this issue is contact_ws, see http://dev.mysql.com/doc/refman/5.1/en/string-functions.html#function_co...

It would be cool if there would be simpletests for this handler type.

Uploading the test separately to see that it fails, and adding it to the .info file.

Okay, rewrote a chunk of the test.

Okay, I hate override_option.

#8: views-1494226-8-test-only.patch queued for re-testing.

#8: views-1494226-8.patch queued for re-testing.

git.d.o went down, hence the retests.

The test was very close, glad to have more coverage (even though we'll now have more than 1337 tests)

+++ b/tests/handlers/views_handler_filter_combine.testundefined
@@ -0,0 +1,108 @@
+    $fields = $view->display['default']->handler->options['fields'];
+    $fields += array(
+      'job' => array(
+        'id' => 'job',
+        'table' => 'views_test',
+        'field' => 'job',
+        'relationship' => 'none',
+      ),
+    );
+    $view->display['default']->handler->override_option('fields', $fields);

This part is the only reason I didn't RTBC. There seems to be no better way to do it, but I wanted to check.

+++ b/tests/handlers/views_handler_filter_combine.testundefined
@@ -0,0 +1,108 @@
+    $fields += array(
+      'job' => array(
+        'id' => 'job',
+        'table' => 'views_test',
+        'field' => 'job',
+        'relationship' => 'none',
+      ),
+    );
+    $view->display['default']->handler->override_option('fields', $fields);

From my experience you can use
$view->display['default']->display_options['fields']['foo'] = array(id' => 'job'...) but if it works things like that doesn't matter that much. Just changed it and committed it.

Thanks for the work!!

If the compound filter will be backported this fix should be considered as well.

I KNEW there was a way to do it. I kept trying to add to $view->display['default']->handler->options['fields'] and $view->display['default']->options['fields'], which made it show up, but not get added to $this->view->fields. Thanks!

The Drupal 6 branch is no longer supported, please check with the D6LTS project if you need further support. For more information as to why this issue was closed, please see issue #3030347: Plan to clean process issue queue