Features integration it's very interesting, i'll work on this to this module.

CommentFileSizeAuthor
#10 features-integration-1494532-10.patch3.53 KBrob c
#5 empty_page-7.x-1.x-dev-1494532-5.patch29.23 KBjpklein
#2 empty_page-7.x-2.0-alpha.zip22.51 KBjpklein
#1 features-integration-1494532-1.patch4.43 KBtoleillo

Comments

toleillo’s picture

toleillo commented
StatusFileSize
new features-integration-1494532-1.patch4.43 KB

Hi,

I attached the patch to integrate features on empty_page module. Not work perfect but is a good aproach to the expected. If accept this patch maybe i can improve this functionallity.

Thanks.

jpklein’s picture

jpklein commented
StatusFileSize
new empty_page-7.x-2.0-alpha.zip22.51 KB

I started using empty_page for a project and independently integrated it with ctools exportables/features. As I rewrote a sizeable portion of code, I am attaching the complete module as a proposed 2.0-alpha version. It's working great in my environment and includes the patch for the recently-resolved 404 issue, though we should probably compare with toleillo's patch in order to assimilate the best practices.

Cheers!

adamgerthel’s picture

adamgerthel commented

@jpklein I'm using your module now. It works very well

Rob_Feature’s picture

Rob_Feature commented

Can this be posted as a patch so the maintainer can roll it in? (and so we can see what you actually did easily)?

jpklein’s picture

jpklein commented
Status: Active » Needs review
StatusFileSize
new empty_page-7.x-1.x-dev-1494532-5.patch29.23 KB

Here's an updated version of my proposed changes as a patch to the latest dev version of code.

Rob_Feature’s picture

Rob_Feature commented
Status: Needs review » Needs work

This patch pretty much makes empty page croak for me. If I try and edit an existing callback I get:

PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'callback_id' in 'where clause': SELECT t__0.* FROM {empty_page} t__0 WHERE (callback_id IN (:db_condition_placeholder_0)) ; Array ( [:db_condition_placeholder_0] => ) in ctools_export_load_object() (line 457 of /Drupal/sites/all/modules/contrib/ctools/includes/export.inc).
The website encountered an unexpected error. Please try again later.
jpklein’s picture

jpklein commented

Ah.. well, that's to be expected; there's no update routine for current installations. Mostly because ctools exportables require a 'machine name' field as the primary database key rather than an auto-incrementing integer and I don't have much experience writing schema-update routines. Feel free to iterate on the install file if you have any insight into how this might work.

adamgerthel’s picture

adamgerthel commented

I tried the patch but it fails for me using the latest dev (7.x-1.0+4-dev). Is there any reason why it doesn't apply cleanly?

Nick Robillard’s picture

Nick Robillard commented

We have a few features being developed in tandem here. Let's work on getting #1506622: Permissions rolled in first.

Nick Robillard’s picture

Nick Robillard commented
Issue summary: View changes

Change body of the comment.

rob c’s picture

rob c commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new features-integration-1494532-10.patch3.53 KB

Whats the plan here, is the custom module with ctools etc going to be implemented? Else let's start some new issues for these and let's reroll the patch in this issue (The original), so we can commit and use this.

Attached is the original patch rerolled, without any other code that fixes a minor t() bug and 2 changes to the feature api definition, but it still needs a bit more work i guess.

marcoka’s picture

marcoka commented

the attached: empty_page-7.x-2.0-alpha.zip
destroyed the settings ui completely. listing is incorrect and no callback can be added anymore.

[16-Jul-2014 17:56:11 UTC] PHP Fatal error:  Cannot redeclare empty_page_features_export_options() (previously declared in /mnt/www/WORKSPACE_DRUPAL/EIGENE_PROJEKTE/PRODUCT_DISTRI3/sites/all/modules/contrib/features/includes/features.ctools.inc(32) : eval()'d code:1) in /mnt/www/WORKSPACE_DRUPAL/EIGENE_PROJEKTE/PRODUCT_DISTRI3/sites/all/modules/contrib/empty_page/empty_page.features.inc on line 23
[16-Jul-2014 17:56:11 UTC] PHP Stack trace:
[16-Jul-2014 17:56:11 UTC] PHP   1. {main}() /mnt/www/WORKSPACE_DRUPAL/EIGENE_PROJEKTE/PRODUCT_DISTRI3/index.php:0
[16-Jul-2014 17:56:11 UTC] PHP   2. menu_execute_active_handler() /mnt/www/WORKSPACE_DRUPAL/EIGENE_PROJEKTE/PRODUCT_DISTRI3/index.php:21
[16-Jul-2014 17:56:11 UTC] PHP   3. call_user_func_array() /mnt/www/WORKSPACE_DRUPAL/EIGENE_PROJEKTE/PRODUCT_DISTRI3/includes/menu.inc:517
[16-Jul-2014 17:56:11 UTC] PHP   4. drupal_get_form() /mnt/www/WORKSPACE_DRUPAL/EIGENE_PROJEKTE/PRODUCT_DISTRI3/includes/menu.inc:517
[16-Jul-2014 17:56:11 UTC] PHP   5. drupal_build_form() /mnt/www/WORKSPACE_DRUPAL/EIGENE_PROJEKTE/PRODUCT_DISTRI3/includes/form.inc:130
[16-Jul-2014 17:56:11 UTC] PHP   6. drupal_retrieve_form() /mnt/www/WORKSPACE_DRUPAL/EIGENE_PROJEKTE/PRODUCT_DISTRI3/includes/form.inc:350
[16-Jul-2014 17:56:11 UTC] PHP   7. call_user_func_array() /mnt/www/WORKSPACE_DRUPAL/EIGENE_PROJEKTE/PRODUCT_DISTRI3/includes/form.inc:841
[16-Jul-2014 17:56:11 UTC] PHP   8. features_export_form() /mnt/www/WORKSPACE_DRUPAL/EIGENE_PROJEKTE/PRODUCT_DISTRI3/includes/form.inc:841
[16-Jul-2014 17:56:11 UTC] PHP   9. _features_export_form_components() /mnt/www/WORKSPACE_DRUPAL/EIGENE_PROJEKTE/PRODUCT_DISTRI3/sites/all/modules/contrib/features/features.admin.inc:186
[16-Jul-2014 17:56:11 UTC] PHP  10. _features_export_build() /mnt/www/WORKSPACE_DRUPAL/EIGENE_PROJEKTE/PRODUCT_DISTRI3/sites/all/modules/contrib/features/features.admin.inc:319
[16-Jul-2014 17:56:11 UTC] PHP  11. features_populate() /mnt/www/WORKSPACE_DRUPAL/EIGENE_PROJEKTE/PRODUCT_DISTRI3/sites/all/modules/contrib/features/features.admin.inc:549
[16-Jul-2014 17:56:11 UTC] PHP  12. drupal_alter() /mnt/www/WORKSPACE_DRUPAL/EIGENE_PROJEKTE/PRODUCT_DISTRI3/sites/all/modules/contrib/features/features.export.inc:21
[16-Jul-2014 17:56:11 UTC] PHP  13. module_implements() /mnt/www/WORKSPACE_DRUPAL/EIGENE_PROJEKTE/PRODUCT_DISTRI3/includes/module.inc:1021
[16-Jul-2014 17:56:11 UTC] PHP  14. module_load_include() /mnt/www/WORKSPACE_DRUPAL/EIGENE_PROJEKTE/PRODUCT_DISTRI3/includes/module.inc:740
marcoka’s picture

marcoka commented

patch #10 works with latest dev version.