Tidy and remove unused code: $http_protocol

Looks good to me and passes the bot!

+++ b/core/includes/bootstrap.incundefined
@@ -743,8 +742,7 @@ function drupal_settings_initialize() {
+    $base_root = ($is_https ? 'https' : 'http') . '://' . $_SERVER['HTTP_HOST'];

While this is technically valid PHP to throw a ternary operation in the middle of a string, it's a little strange compared to what we do elsewhere. I actually find the former code a bit easier to read. :\

I would recommend just a patch to get rid of the bunk variable in the if ($base_url) check alone.

Looks good to me. I was just about to post this exact patch.

Committed to 8.x. Thanks.

Adding tags.

Here's a quick backport.

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/5b13080