Closed (fixed)
Project:
Block Access
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
22 Mar 2012 at 19:48 UTC
Updated:
26 Mar 2012 at 19:04 UTC
Jump to comment: Most recent file
The permissions that allow you to modify the block configuration form don't work. I took a quick look at the code and it looks like it's still using the D6 block form structure. Actually the permissions themselves still use D6 block config form terminology (which has changed a bit) I'm guessing you did a quick D7 port and haven't had time to go through it.
I'm going to try and fix this and post a patch (hopefully) today. Let me know your thoughts!
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | d7-upgrade-1494764-1.patch | 32.79 KB | drclaw |
Comments
Comment #1
drclaw commentedSo here's a first attempt at completing the d7 upgrade. So far it's working for me pretty well. I had to modify the permissions a bit to match the new block setup of D7, but the control is pretty granular. There's a permission for pretty much every block element. Of course this doesn't necessarily cover custom blocks with custom fields defined by other modules, just the ones from the block module itself. Also the block administration page seems to be working as expected from the permissions... The permissions are a little complicated, however, and a readme file would be great. I would write one up, but I thought I'd get your thoughts on the patch first.
I should note that I took the approach that the block_access permissions sort of override the 'administer blocks' permission... So essentially you have to have the 'administer blocks' permission enabled before the block_access permissions work. Not sure if this is how you intended to go, but it's working for me so far...
The only problem I'm having right now is related to contextual links. If you don't have the "config all blocks" permission enabled, but you do have a particular block's individual "config block" permission set, the "Configure block" contextual link won't appear... sort of... at least not in blocks placed with context. I had some luck with blocks placed with the blocks administration page, but it wasn't consistent...
Anyway, let me know what you think!
Comment #2
lambic commentedThis looks great, thanks very much for taking it on. I'll look at the patch in more detail over the next couple of days and try to commit it sometime early next week.
Your guess is correct, I did a quick conversion a while back, then got busy with D6 stuff and haven't had a chance to go back to it.
Comment #3
drclaw commentedCool. Good to hear. Thanks for this module, by the way. I don't know why I didn't find it sooner! Most of these permissions should be in core, but that's just my opinion. ;)
Comment #4
lambic commentedPatch committed and pushed. Thanks again.