The item reservation status doesn't seem to be functioning properly. Only guess at this time is it is related to revisions being turned on. I have several items that should be listed as checked out that are instead listed as available. View caching is shutoff
For instance the first camera in this view has been out since the beginning of March. But the history of just the item shows that it is checked out. And if a new reservation is made that item isn't available. So, the problem seems to be contained to just the Item Reservation Status field.
| Comment | File | Size | Author |
|---|---|---|---|
| ensemble048.png | 58.35 KB | iPeat | |
| ensemble047.png | 87.34 KB | iPeat |
Comments
Comment #1
darrick commentedI committed a fix here: http://drupalcode.org/project/merci.git/patch/2b8343c
I found this occurs when you have an item currently checked out and then create a reservation in the future for that same item. On creating the future reservation the correct status was being wiped out.
I've also added a database update to rebuild the statues correctly.
Comment #2
iPeat commentedSeems to have fixed the scenario I first listed. But the opposite is now occurring items that should be available are still listed as checked out. Again only from the Reservation Status field perspective the reservation system still views it as available.
Comment #3
iPeat commentedBand aid: rerunning the database update in #1 will correct any out of sync statuses.
Comment #4
iPeat commentedGot it patch needs to be modified to read
if ($item_status == MERCI_ITEM_STATUS_CHECKED_OUT or ($node->merci_original_reservation_status == 3 and $item_status == MERCI_ITEM_STATUS_AVAILABLE)){instead of
if ($item_status == MERCI_ITEM_STATUS_CHECKED_OUT or ($node->merci_original_reservation_status == MERCI_ITEM_STATUS_CHECKED_OUT and $item_status == MERCI_ITEM_STATUS_AVAILABLE)){Comment #5
darrick commentedThank you iPeat. Good catch. I've just committed your fix here: http://drupalcode.org/project/merci.git/patch/6a7db51
Comment #6
darrick commented