The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Strict warning: Only variables should be passed by reference in panels_breadcrumbs_ctools_render_alter() (line 164 of /opt/development/yourhelps/sites/all/modules/panels_breadcrumbs/panels_breadcrumbs.module).
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | panels_breadcrumbs-strict_byref_fix-1495618-3.patch | 551 bytes | techninja |
| #1 | 1495618-1.patch | 667 bytes | rogical |
| Screenshot at 2012-03-23 15:18:34.png | 13.22 KB | rogical |
Comments
Comment #1
rogical commentedComment #2
devuo commentedCan you tell me your Breadcrumb configuration?
Comment #3
techninja commentedI've also got this problem (I run in e-strict to catch little things like this, they're not killer, but good practice). Really, all PHP wants to say is that you just can't pass the output of end() through drupal_alter, as it's by reference, you'd never be able to change the input because it's not a variable.
Even if you'd never be using it (and I admit it's silly and yet another line of code), passing an actual variable along is the only correct method. See attached patch.
Comment #4
perignon commentedI applied the patch in #3 and it works. Fixes the strict warnings.
Comment #5
budalokko commentedI applied the patch in #3 too and fixed strict warning and module still works as expected.
Comment #6
ruplSame issue: no malfunctions in the code, but ran into this warning with strict warnings turned on.
Giving patch in #3 RTBC++
Comment #7
devuo commentedThanks for your contribution, this problem has been fixed in the 7.x-1.x-dev branch. A 7.x-1.x version will be released soon with the fix.