Looks like this was overlooked in a variable change.
The patch fixes a warning and adds some more info to a few log/message calls. Tried to make it look the same as most other printed/logged error messages.

CommentFileSizeAuthor
#2 drealty_disconnection_error.patch2.54 KBtwod
drealty_error_msgs.patch2.72 KBtwod

Comments

camidoo’s picture

camidoo commented
Status: Needs review » Fixed

Committed. Thanks TwoD!

twod’s picture

twod
Primary language Swedish
Location Sweden
commented
Status: Fixed » Needs work
StatusFileSize
new drealty_disconnection_error.patch2.54 KB

Follow up patch since I was getting

PHP Warning: Unknown: DrupalPrivateStreamWrapper::stream_write is not implemented! in Unknown on line 0

when editing resources after this change went in.

I think the problem is that CURL in phRets tries to write to the debug log after the stream wrapper class has been deconstructed.
Properly disconnecting phRets calls curl_close() and fclose(), flushing anything left in the stream before PHP destroys any lingering objects.

This should also show a convenient watchdog message if a disconnect call is missed somewhere.

twod’s picture

twod
Primary language Swedish
Location Sweden
commented
Status: Needs work » Needs review

Wrong status...

camidoo’s picture

camidoo commented
Status: Needs review » Closed (fixed)