Closed (fixed)
Project:
Panels
Version:
5.x-2.0-alpha2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Jun 2007 at 21:13 UTC
Updated:
9 Jul 2007 at 15:18 UTC
Jump to comment: Most recent file
Comments
Comment #1
summit commentedSorry about last post.
The panels are shown, but you need to use the content tab after the panels page.
But I experienced something else what I think is a bug.
When I click the + on the Panels-Content TAB, I got a popup with in the middle a nice drupal logo, which flickers a little bit, but then nothing happens.
I waited more than 30 minutes..
greetings,
Martijn
Comment #2
merlinofchaos commentedI'm sorry, you need to be more precise with your bug report. I don't understand what you're trying to tell me.
Comment #3
summit commentedHi,
A picture says more than words!
See attached picture. If you click on the icon with the + you get the popup in the middle.
But the popup is not filled with content. I waited for more than 30 minutes.
Hopefully the picture is clear?
greetings and thanks allready for this great module,
Martijn
Comment #4
merlinofchaos commentedWhat version of PHP are you using? (Please change state of issue back to 'active' when you answer this; thanks)
Comment #5
merlinofchaos commentedAlso, I've found out that devel.module can interfere. Trying to figure out how to force it not to. If you're using devel.module, you may need to turn off all its output for this to work.
Comment #6
summit commentedHi Merlin,
Yes disabling the devel-module made the trick!
I will report other testing also.
greetings and thanks for your reply.
Martijn
Comment #7
merlinofchaos commentedChanging title to be descriptive.
Comment #8
merlinofchaos commentedI've fixed the Panels portion of this, but devel.module still needs to be fixed too.
Comment #9
moshe weitzman commentedwhat needs to be fixed? devel already stays out of the way if a page properly identifies itself as text/javascript. if a page says that it is texct/html but really returns javascript, then it deserves the mangling it gets.
Comment #10
merlinofchaos commentedNo, it doesn't. Clearly, you've never actually tried the piece of code that is supposed to test for that, because if you had you'd know it doesn't actually work.
Also, your $GLOBALS['devel_shutdown'] switch is broken, really really obviously broken just looking at the code. Test that too.
Now, to be less cranky-bitchy about this (though it's hard; I always get cranky-bitchy when people point their finger at me and say "It's your bug" over and over again when it's really easy to show that it's NOT), here's what's wrong:
devel.module tests for the word *html* in drupal_get_headers(). The problem is, the place this gets set is during drupal_bootstrap, long before my code has gotten called. So the header to declare everything 'text/html' is already set. I can set a new header, but the drupal_set_header() is additive; it doesn't overwrite the already set text/html header. So the test for *html* always succeeds, therefore assuming all pages are html.
The test against $GLOBALS['devel_shutdown'] is so stupidly broken it deserves no explanation.
Comment #11
moshe weitzman commenteddevel changed per earl's suggestion.
Comment #12
amitaibuI'm not sure the title is correct, since I experience the same issue - but devel.module is not installed...
Comment #13
(not verified) commented