$_REQUEST variable should never be overwritten, since other modules could rely on it.

CommentFileSizeAuthor
#1 do-not-overwrite-request-variable-1496310-1.patch1.41 KBNorberto Ostallo

Comments

Norberto Ostallo’s picture

Norberto Ostallo commented
Status: Active » Needs review
StatusFileSize
new do-not-overwrite-request-variable-1496310-1.patch1.41 KB

This patch introduces a new variable that is used in stead of directly writing into $_REQUEST.

jbrauer’s picture

jbrauer commented
Status: Needs review » Postponed (maintainer needs more info)

While it's arguably generally the case that modules shouldn't overwrite $_REQUEST the very limited scope where preopulate does so here. This would seem to be the only case where this is happening:

    parse_str(base64_decode($_REQUEST['pp']), $_REQUEST);

This could be handled by storing the decoded request and merging it with the original $_REQUEST variable.

Thoughts?

jbrauer’s picture

jbrauer commented
Status: Postponed (maintainer needs more info) » Fixed

Marking as fixed. Can always re-open if there is further discussion.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.