Closed (duplicate)
Project:
D7 Media
Version:
7.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
23 Mar 2012 at 16:17 UTC
Updated:
5 Oct 2012 at 14:39 UTC
Jump to comment: Most recent file
Comments
Comment #1
dave reidAwesome. I know for sure we at least want to have
<audio>and<video>native tag support in Media. Maybe we add some simple support first but then I would love for us to be able to support a fully-featured player included in Media. It makes total sense to do.Comment #2
travist commentedHere is a visual diff of this patch: https://github.com/travist/drupal-media-module/compare/7.x-2.x...7.x-2.x...
Comment #3
travist commentedComment #4
dmurkerson commentedHello:
I've just tried to apply this patch to the 2.0 dev version of the Media module on my Drupal 7 site according to these instructions: http://drupal.org/patch/apply and I'm getting "Hunk Failed" errors.
I'm trying to incorporate the Media module into Wysiwyg so that I can upload media files and have them display in a player on my site. This patch was listed on the Media main project page as an update to be able to do this.
Any help would be appreciated.
Thanks,
Danielle
Comment #5
tsvenson commented@dmurkerson: Hunk failed means that the patch couldn't be applied cleanly. This usually is due to that since the patch was created, a lot of other code has been committed to the project, casing this patch the be "out-of-sync" so to speak.
To fix it you need to manually apply the patch. Alternatively wait until someone re-rolls the patch against a current checkout of the code.
Comment #6
dmurkerson commentedYes, that is why I commented on this. I began to apply it manually (I'm no stranger to code) however, since there were so many files this patch was fixing/creating I thought it best to use the patch functionality in Linux to do it for me so that there would be less chance I'd miss something in applying it manually.
I'll keep watch here and elsewhere as well as apply it myself again and see if that helps.
Thanks.
Comment #7
travist commentedI will work on getting an updated patch and player.
Comment #8
dddave commentedjfyi I linked to this issue in http://groups.drupal.org/node/233238
Comment #9
pschuelke commentedThe patch does indeed have hunk errors when applying.
I just tried to do a manual install of the #2 patch with 2.x dev. It doesn't seem to like to play with the most recent changes.
Comment #10
pschuelke commentedThere is a patch that does this here.
Comment #11
devin carlson commentedAs mentioned in #10, this issue belongs to file entity.
#1748952: Add simple HTML5 file field formatters for <audio> and <video>