Error When Selecting 'Send invoice receipt email' in Rules as an Action

There appears to be a collision with the defined name of the Rules action in the hook_rules_action_info() implementation. Defined actions look for a configuration form with a function name of ACTIONNAME_form(), so the action "commerce_invoice_receipt_mail" is erroneously trying to use the form function commerce_invoice_receipt_mail_form(), which does something else entirely.

More careful namespacing of actions should fix this. Patch attached.

Changing status.

This patch works for me. Thank you.

This doesn't work for me. If I apply the patch, I get "Unknown action commerce_invoice_receipt_mail".

If I try to enter the action "send invoice receipt mail", the page doesn't load but displays this message:

Notice: Undefined property: RulesReactionRule::$order_id in commerce_invoice_receipt_mail_form() (Line 13 ... /commerce_invoice_receipt.admin.inc).
Notice: Undefined property: RulesReactionRule::$mail in commerce_invoice_receipt_mail_form() (Line 19 ... /commerce_invoice_receipt.admin.inc).

@papalapapp: try flushing your caches, then delete the action from the rule entirely and re-add the action back in.

accidental triple post.

accidental triple post.

Tripple post? o.O Too much coffee?

Re-adding the action did it. Thanks!

My recommendation is to change the form id of the form "commerce_invoice_receipt_mail_form" instead of changing the id of the rule, because in that way, the rulesets still work. I think less people care that the form id has changed as opposed to the number of people that are influenced when the rule id is changed.

[edit]
I changed the name of the form to commerce_invoice_receipt_mail_admin_form and that works fine.

Patch didn't work, but #9 worked for me.

To clarify, I manually applied the change recommended in #9, after applying the patch. So possibly both were necessary, don't know...

Applied patch and fixed form name.

Fix status