Formerly, in 7.x, during the install process, specifying an incorrect database, username, or password on the install.php?langcode=en&profile=standard step would result in an error message being shown in an errorbox, and the database details entry form being re-displayed. Currently, in 8.x, that is not happening; instead, the raw PDO error message is being displayed "flat" (that is, without special formatting), and the database details form does not follow it.

Comments

dpovshed’s picture

dpovshed commented

I did a small research and can confirm that we have something weird here.

Seems that try/catch block defined in the Tasks::connect() function (defined in core/lib/Drupal/Core/Database/Install/Tasks.php ) cannot catch the exception and the exception going to very top handler.

Something might be wrong with class instantiantion.

David_Rothstein’s picture

David_Rothstein commented
Status: Active » Closed (duplicate)

Not sure how I missed this when I was filing my issue - sorry about that. But since the patch at #1506630: Namedspaced code throws and catches "Exceptions" which don't exist (causing the DB settings form validation to break on install) should fix this problem, let's close it as a duplicate.

David_Rothstein’s picture

David_Rothstein commented
Issue summary: View changes

Clarifying that this is an 8.x issue, not a 7.x one (in case anyone didn't read the version tag).