Couple of changes to clean it up have it match what I'd done for media_vimeo.

CommentFileSizeAuthor
#6 media-youtube-drewish-update-1497014-6.patch3.04 KBRobW
#3 media-youtube-drewish-update-1497014-3.patch2.54 KBRobW
media_youtube.patch3.26 KBdrewish

Comments

RobW’s picture

RobW commented

Hey Drewish, do you think we can apply these to Media: Youtube 2.x without any changes? I'm not too familiar with the stream wrapper side of things.

RobW’s picture

RobW commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
RobW’s picture

RobW commented
StatusFileSize
new media-youtube-drewish-update-1497014-3.patch2.54 KB

Here's a re-roll against 2.x. Testing and code review appreciated.

dddave’s picture

dddave commented
Status: Needs review » Needs work

Hunk 1 failed at 10.

edit: Hold your breath for a little while...

edit2: Nope, cannot get it to go.

RobW’s picture

RobW commented

Might have rolled this against some other changes I'm testing. Will take a closer look tomorrow.

RobW’s picture

RobW commented
Status: Needs work » Needs review
StatusFileSize
new media-youtube-drewish-update-1497014-6.patch3.04 KB

Re-rolled against the ever-changing dev. Should apply cleanly.

RobW’s picture

RobW commented
Status: Needs review » Fixed

These are pretty simple changes and have been working for a couple of months on Media: Vimeo, so committed: http://drupalcode.org/project/media_youtube.git/commit/79baf10.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.