The extension field is too short: maxlength="64"
I think it should be longer, for example:
txt doc odt xls jpg gif tif pdf png ods rtf mp3 ogg wma zip rar

eats all the space.

CommentFileSizeAuthor
#7 149789.patch272 bytesowen barton
#6 149789.patch854 bytesowen barton

Comments

jjk005’s picture

jjk005 commented

The question becomes, is it safe to change that number in the form? Or is there something that would make such an edit problematic? I too need this field to be longer.

jpetso’s picture

jpetso commented

I looked this up, and it goes this way:

  • All the settings, including the allowed extensions, are stored by CCK in a serialized array.
  • I have already forgotten the database table, but the field is of the type "mediumtext".
  • "mediumtext" is long enough to store good amounts of allowed extensions.
  • Let's remove the maxlength restriction! I'll ask dopry and commit that afterwards.
jpetso’s picture

jpetso commented

The table is {node_field_instance}, and I decided that it's trivial enough to not having to ask dopry for this. Committed and FIXED. Rejoice.

jpetso’s picture

jpetso commented
Status: Active » Fixed

And when I say FIXED, I certainly want to set the status accordingly. Ungh.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
owen barton’s picture

owen barton commented
Version: 5.x-1.x-dev » 6.x-3.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new 149789.patch854 bytes

It looks like this regressed at some point - check around line 25 of:
http://drupalcode.org/viewvc/drupal/contributions/modules/filefield/file...
http://drupalcode.org/viewvc/drupal/contributions/modules/filefield/file...

Attached is a simple patch that fixes this.

owen barton’s picture

owen barton commented
StatusFileSize
new 149789.patch272 bytes

Actually, that was the wrong fapi parameter - this one is correct...

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Reviewed & tested by the community

Thanks, looks good to me.

quicksketch’s picture

quicksketch
he/him
commented
Title: file extension field too short » File extension field too short
Version: 6.x-3.x-dev » 6.x-3.5
Status: Reviewed & tested by the community » Fixed

Committed to CVS. It'll be in 3.6.

owen barton’s picture

owen barton commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.