Attached patch includes coder_format.cmd, a Windows batch script for executing Coder Format by click (via Windows Explorer context menu) on single PHP files or complete directory trees.

The script comes along with a Windows registry file to install the Windows Explorer context menu items and another one to remove them.

README is removed and replaced by README.txt, including detailed step-by-step installation instructions.

CommentFileSizeAuthor
#6 coder-DRUPAL-5--2.installer.patch32.94 KBsun
#5 coder-DRUPAL-6--1.installer.patch11.43 KBsun
#4 batch.inc_.patch11.25 KBezyang
#2 actions.patch4.83 KBezyang
#1 coder_format-3.patch1.86 KBezyang
coder_format.windows-installer.patch7.37 KBsun

Comments

ezyang’s picture

ezyang commented
StatusFileSize
new coder_format-3.patch1.86 KB

The first order of business is to get coder_format working on Windows. This patch fixes a number of problems I found. Specifically:

  • There were bad replacements for Windows/Mac newline normalization, resulting in literal "\n"s all over the place
  • coder_postprocessor_array_rearrange totally nukes the file contents, so it had to be completely disabled. I'll see if I can fix it.
  • A conf_path() dependency was recently added, so I stubbed that function too

Coder needs a dose of its own medicine, but that will be done in good time. :-)

ezyang’s picture

ezyang commented
Assigned: sun » ezyang
StatusFileSize
new actions.patch4.83 KB

Here are the changes coder identified for the action.inc file. Most of them are sensible, but a few are hazy. Specifically:

  • -46,9 +47,9; -75,12 +76,13; -93,9 +95,9: The spacing added to justify the three assignments seems excessive. Maybe coder should have an "upper limit" of how far it goes before it gives up and starts another batch?
  • -210,9 +211,9: Coder appears to have collapsed the indent here; how curious!
ezyang’s picture

ezyang commented
Assigned: ezyang » Unassigned

Ehh... I posted these two patches on the wrong issue! Oops!

ezyang’s picture

ezyang commented
StatusFileSize
new batch.inc_.patch11.25 KB

post scrubbed

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Assigned: Unassigned » sun
Category: feature » task
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new coder-DRUPAL-6--1.installer.patch11.43 KB

As promised, here is a patch that updates the coder_format Windows installer to my latest version (in use), fixes the start-up script coder_format.php, and also fixes some pre/post-processors that are not yet working (and part of http://drupal.org/node/208767).

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new coder-DRUPAL-5--2.installer.patch32.94 KB

Same patch for 5.x-2.x.
Includes updated inline documentation of 6.x.

@Doug/Stella: Please commit this as soon as possible, so ezyang can use the latest code for the GHOP task.

douggreen’s picture

douggreen commented
Status: Reviewed & tested by the community » Fixed

committed, also @sun, please see email I sent to you. Thanks!

douggreen’s picture

douggreen commented
Status: Fixed » Reviewed & tested by the community

doh! I just noticed that I committed this against 5.x and not 6.x. You might want to fix this yourself.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed to 5.x and 6.x branches.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.