EXAMPLE USING RENDERABLE ARRAYS in readme
not works because has extra semicolon

Comments

Pierre.Vriens’s picture

Title: Example broken in readme file » Example broken in README.txt file
Issue summary: View changes
Status: Active » Postponed (maintainer needs more info)
Parent issue: » #2369883: Create chart documentation

I'm assuming "readme" should actually be "README.txt, if not please correct me.

To complete the details about this issue, can anybody answer these questions I have about this issue:

  1. I seem to understand we're talking about http://cgit.drupalcode.org/chart/tree/README.txt, the link I found by navigating from the project page, using the "repository viewer", and then using the tree link. Are we talking about the same thing?
  2. If so, the project page points to another URL (ie http://drupalcode.org/project/chart.git/blob/refs/heads/7.x-1.x:/README.txt), which I'd like to update to the URL in my previous bullet, even though in the end it's the same (= remove potential confusion).
  3. The example referred to in the README.txt contains multiple lines containing a semicolon. What's the line nr in it where that semicolon is to be removed?

After somebody gets back with the answers to my questions, I'd be happy to help get this (tiny) issue resolved. In the meantime: note the status update of this ticket "for now" ...

boombatower’s picture

Looks like,

$page['chart'] = array(
  '#theme' => 'chart',
  '#chart_id' => 'test_chart',
  '#title' => t('Servings'),
  '#type' => CHART_TYPE_PIE_3D,
  '#data' => array(
    'fruits' => 3,
    'meats' => 2,
    'dairy' => 5,
  ); <-----------
);

boombatower’s picture

Assigned: Unassigned » boombatower
Status: Postponed (maintainer needs more info) » Fixed

Seems like having a link with branch in it to be explicit is better since you will be making 7.x-2.x which will probably have a readme in it as well and should be referenced different on project page (if at all).

Update both links https://www.drupal.org/node/206038/revisions/view/6719541/7807785 and fixed example http://cgit.drupalcode.org/chart/commit/?id=83399e50dfbf5eb595870ff94968....

Pierre.Vriens’s picture

Thanks Jimmy! Just a minor fix and a link correction, but it results in a very first fixed issue related to chart which I somehow "contributed" to ... I know it's really not the end of the world, but hey ... step by step, brick by brick, or something like that.

Unless I hear different, I'm going to assume that for the chart module the policy to get issues in status CLOSE is to just use status fixed, then wait for 2 weeks (during which people interested in following the issue queue have a chance to notice those fixed issues), and after 2 weeks let the D.O system automatically close the issue.

boombatower’s picture

Yea, that's what we've been doing. Also great issue triage you've been doing, sorry about jumping the gun. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.