Custom search pages are now exportable (great work!). However, when you enable a feature that includes an exported search page, the path for that page is broken.

This happens because the list of available search pages relies on a database query, but feature-based search pages do not live in the database.

Comments

milesw’s picture

Status: Active » Needs review
StatusFileSize
new1.46 KB

Turns out it's a simple fix. Replaced the database query in apachesolr_search_menu_alter() with apachesolr_search_load_all_search_pages().

Status: Needs review » Needs work

The last submitted patch, 1498490-1-menu-paths-for-exported-search-pages.patch, failed testing.

nick_vh’s picture

Status: Needs work » Needs review
StatusFileSize
new5.83 KB

This should be better

nick_vh’s picture

This patch allows reverting search pages to their in-code variant.

https://skitch.com/nick_vh/8qdas/apache-solr-search-smartphone-compare

nick_vh’s picture

StatusFileSize
new8.23 KB

Forgot to attach it!

nick_vh’s picture

Status: Needs review » Patch (to be ported)

Committed

nick_vh’s picture

Version: 7.x-1.x-dev » 6.x-3.x-dev
milesw’s picture

Excellent, thanks Nick. It's great having pages and environments exportable.

phoenix’s picture

Great news Nick. We had the same problem here. Will try it out.
Just saw you changed t he version to drupal 6. Is it also fixed in the drupal 7 version?

nick_vh’s picture

It has been committed to 7.x-1.x, needs a backport for the 6.x-3.x version :-)

nick_vh’s picture

StatusFileSize
new3.96 KB
nick_vh’s picture

Status: Patch (to be ported) » Closed (fixed)

Fixed for all