switch from drush 4 to 5, not sure what might be causing this

$ drush make ../makefile.make
Make new site in the current directory? (y/n): y
drupal-7.12 downloaded.                                                                                      [ok]
...
 >> admin_menu-7.x-3.0-rc1 downloaded.                                                                       [ok]
 >> addressfield-7.x-1.0-beta2 downloaded.                                                                   [ok]
$ ls -al
total 236
drwxr-xr-x  9 brian www-data  4096 2012-03-23 04:33 .
drwxrwxr-x  8 brian www-data  4096 2012-03-23 04:31 ..
-rw-r--r--  1 brian brian     6605 2012-03-23 04:33 authorize.php
-rw-r--r--  1 brian brian    65014 2012-03-23 04:33 CHANGELOG.txt
-rw-r--r--  1 brian brian      996 2012-03-23 04:33 COPYRIGHT.txt
-rw-r--r--  1 brian brian      720 2012-03-23 04:33 cron.php
drwxr-xr-x  4 brian brian     4096 2012-03-23 04:33 includes
-rw-r--r--  1 brian brian      529 2012-03-23 04:33 index.php
-rw-r--r--  1 brian brian     1451 2012-03-23 04:33 INSTALL.mysql.txt
-rw-r--r--  1 brian brian     1874 2012-03-23 04:33 INSTALL.pgsql.txt
-rw-r--r--  1 brian brian      688 2012-03-23 04:33 install.php
-rw-r--r--  1 brian brian     1298 2012-03-23 04:33 INSTALL.sqlite.txt
-rw-r--r--  1 brian brian    17856 2012-03-23 04:33 INSTALL.txt
-rw-rw-r--  1 brian brian    18092 2012-03-23 04:33 LICENSE.txt
-rw-r--r--  1 brian brian     7960 2012-03-23 04:33 MAINTAINERS.txt
drwxr-xr-x  4 brian brian     4096 2012-03-23 04:33 misc
drwxr-xr-x 42 brian brian     4096 2012-03-23 04:33 modules
drwxr-xr-x  5 brian brian     4096 2012-03-23 04:33 profiles
-rw-r--r--  1 brian brian     3494 2012-03-23 04:33 README.txt
-rw-r--r--  1 brian brian     1561 2012-03-23 04:33 robots.txt
drwxr-xr-x  2 brian brian     4096 2012-03-23 04:33 scripts
drwxr-xr-x  4 brian brian     4096 2012-03-23 04:33 sites
drwxr-xr-x  7 brian brian     4096 2012-03-23 04:33 themes
-rw-r--r--  1 brian brian    19338 2012-03-23 04:33 update.php
-rw-r--r--  1 brian brian     9642 2012-03-23 04:33 UPGRADE.txt
-rw-r--r--  1 brian brian     2051 2012-03-23 04:33 web.config
-rw-r--r--  1 brian brian      417 2012-03-23 04:33 xmlrpc.php

Comments

osman’s picture

ditto

drush make (5.0) omits .htaccess file.

I tried with 2 different .make files;
one with regular drupal core, one with pressflow.

Both core selections ended up with no .htaccess

jhedstrom’s picture

Priority: Major » Critical

Bumping to critical. The issue that broke this was the move to use drush_scan_directory() in make_move_build() (#1490090: Replace direct cp, ls and mv calls with drush_copy_dir, drush_scan_directory and drush_move_dir).

The issue that prevented us from noticing is that the tests have never properly hashed .htaccess, so that will need to be fixed as well so this doesn't happen again.

jhedstrom’s picture

Status: Active » Fixed

The reason the tests were still passing is that the .htaccess file was actually being hashed. The bug happened between the hashing and the moving of the build. I've committed a fix so the .htaccess file is now properly moved, but at some point, that gap in test coverage needs to be closed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.