Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is just a quick cleanup of based on Coder's review. Simple things. Got to it only because of a bug in Coder.
Comment | File | Size | Author |
---|---|---|---|
#3 | sharethis-code_clean-1498768-3.patch | 61.66 KB | hswong3i |
sharethis-coder-1.patch | 2.33 KB | mgifford | |
Comments
Comment #1
RobLoachThanks! http://drupalcode.org/project/sharethis.git/commit/57119f9
Comment #3
hswong3i CreditAttribution: hswong3i commentedMore cleanup with:
P.S. For verify changes beside white space and indentation, please apply patch and run "git -w -b HEAD" ;-)
Comment #4
hswong3i CreditAttribution: hswong3i commentedAnyone can give a hand for the review? Since I would like to start contribute for #1812382: Add bar style as display options? after code cleanup ;-)
Comment #5
RobLoachSome of those files are external files from ShareThis, so I left those changes out. Otherwise, looks good! Thanks a lot. http://drupalcode.org/project/sharethis.git/commit/a28f68a