Add body field for Polls

This is a much needed feature, IMO. It allows people to provide some context with polls.

The code looks nice and simple. I've to go right now but passing FALSE to check_markup can be very dangerous (security). I'll have to verify that later on but already wanted to show support for this patch.

I encourage others to review the security implications of this patch as well. I want at least one other person to have a close look at it.

Regarding check_markup() the same call (with $check=FALSE) is used in node.module as well to filter body/teaser in node_prepare(). Whats different here? I thought access check was performed in node_access() before the hook_view() is even called. But I will take a closer look at it, too.

Previous patch was missing one argument in hook_theme. The description is only displayed in page view (vote form and results) and the block, but it is not part of the teaser. Should it be added to the teaser as well? Not sure this makes sense ...

Here is an updated patch containing the fixes to poll module (from http://drupal.org/node/149879) and the description feature. Sorry! I dont have time to manually separate them now, but I will happily reroll this patch once the 'broken' poll patch is in.

Thanks Dries for your comments. I'm marking this CNW to ...

1. fix the css: I'm currently using the 'description' class to style the output, which is used for description of form fields. Creating a new 'poll-description' class or stg. will allow use to style the description of polls separatly and make it 'regular' by default.
2. I will also take a close look at the check_markup() stuff to understand why also node.module calls it with $check = FALSE and to find out if there are any security implications.

Expect a new patch in a few hours ...

... still needs review ...

I didnt have time for thorough testing (maybe tomorrow), but here is a patch for latest HEAD. Comments are welcome ;)

Not because it adds a string, but because it modifies behavior. Make sure to get this in poll module early in D7.

Rewritten patch to include generalized body field flow. I know I'm killing extra kitten in first change(that's a bug).

The last submitted patch failed testing.

Patch looks good to me (except for the RSS issue, but that might just be my ignorance :) ).

• I created a poll, then applied this patch. The "old" poll still behaved as expected (ie not broken).
• Added a body field (by setting the title for the body field) to the poll and entered some content. Worked as expected.
• I set RSS to publishing to "Title + Teaser". Based on looking through the code, I expected a bulleted list of possible poll answers (preceded by '*'). However, I did not see a difference in RSS output between "Title + Teaser" and "Full Text". Is this a bug or am I misunderstanding something? I did see the poll vote count in the RSS output, but no '*'.
  
  function poll_nodeapi_rss_item($node) {
  $teaser = '';
  if (is_array($node->choice)) {
    foreach ($node->choice as $k => $choice) {
      if ($choice['chtext'] != '') {
        $teaser .= '* ' . check_plain($choice['chtext']) . "<br />";
      }
    }
  }
  $node->teaser = $teaser . $node->teaser;
}
• Visually inspected the patch and could not find any problem.

Should we add additional tests to poll.test for this change?

Are any of the patches suitable for D6, or should I give up on the notion of finding a solution for adding a poll description in a D6 implementation?

In the mean time this does not seem to go anywhere.

I tried to add a text field to a poll, for providing comment and context (in D6.17 using CCK).

The field is added alright but in the wrong place. The text appears above the results, instead of below.
Rearranging the fields does not help.

I checked various templates but this does not look encouraging. So polls seem to behave in a rather non-Drupalesque fashion :o)

Update:
A very basis workaround is to enable comments, put your deliverables there, and set the comment options to read-only. This could work for some cases.

Hello, don't know if this issue got any final solution over the last 4 years, but I have bumped into this problem just now.

By accident I discovered the Body Field Label option that is rather hidden. "To omit the body field for this content type, remove any text and leave this field blank." So I figure on filling it out you should get a body field, but I don't.
I did check the manage fields tab. This is under admin/content/types/poll/fields, the suggested, admin/structure/types/manage/poll/display in # 26 doesn't go anywhere. In this list of fields I can see that the Label is Poll-body and the Name (?) is Node Module form (¿so is it poll or node?), there is nothing that can be set there so I understand with this it should just appear in the create a poll page, but it doesn't.

I had been working with a self-created "description" field, which does appear and can be configured. But this field disappears from the page after voting when using ajax-poll. This is probably because ajax-poll does not take custom fields in account. Had been breaking my head over this quite a while and thought the body field label would be the solution...

The patch from #15 is from 2009, I suppose that's not valid anymore and I don't dare to just try it out.

And what the heading of this issue says is not very reassuring, "The patch was initially created a few weeks ago and updated to HEAD, but its difficult to test/review as long as the poll.module is broken ..."

Is the patch from the heading the same patch as #15 or a new "final" one? And is the patch what has been applied to HEAD or should it be used additionally? And in any case, do I have to understand that this CORE module is (still?) simply broken anyway?