Download & Extend

Incorrect SQL for Postgres in cck_address.install

Project:Address field for CCK
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:rconstantine
Status:closed (fixed)

Issue Summary

The attached patch corrects the SQL for Postgres so this module will install correctly. The current code is invalid for a few reasons, but the main one is you do not need the /*!40100 DEFAULT CHARACTER SET UTF8 */ declarations, since that is a MySql specific construct (the number there corresponds to the MySql version number).

I'm not positive a database solution is required for this purpose, but I'll save that for another issue.

AttachmentSize
cck_address.install.patch2.18 KB

Comments

#1

Thanks for the patch. I'll look at getting it in soon. As for the database usage, I need it for my application, and simply released the module in case others could use it. I didn't begin by designing a generally usable module.

However, someone submitted a patch that I need to incorporate that will allow the substitution of text fields for the state and country drop downs. That should make this more widely usable, but still give those of us that need the existing functionality the db stuff. The patch should go in this round of revisions. Look for it in a few days in the dev release.

I also have a case where I know all addresses of users before hand and am building in the ability to draw street names and numbers from a db table of your choice. This will be optional and depends on activeselect. That is, if I can figure out what I'm doing. I just started that and got stuck. We'll see.

Thanks again.

#2

Assigned to:Anonymous» rconstantine
Status:needs review» fixed

Will be in the next dev release.

#3

Status:fixed» closed (fixed)