Ubercart payment gateway.

Sandbox page: http://drupal.org/sandbox/jrobens/1500242

Not sure how to create not have the overly long ubercart_cardaccess_payment_gateway module descriptor.

Thanks
John

Comments

yannickoo’s picture

yannickoo
Location Berlin
commented
Status: Active » Needs work

Check the issues detected by the automated tools: http://ventral.org/node/26/revisions/30/view

To speed up the process of reviewing your code you could try to get a review bonus.

jrobens’s picture

jrobens commented
Status: Needs work » Needs review

Ran through coder suggestions. Applied netbeans presentation template.

soncco’s picture

soncco commented
Status: Needs review » Needs work

Hello!

  • It appears you are working in the "master" branch in git. You should really be working in a version specific branch.
  • Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
  • Remove "version" from the info file, it will be added by drupal.org packaging automatically.
  • Remove "project" from the info file, it will be added by drupal.org packaging automatically.
  • Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically.
  • The "?>" PHP delimiter at the end of files is discouraged, see http://drupal.org/node/318#phptags

Please check and use pareview tool to fix them http://ventral.org/pareview/httpgitdrupalorgsandboxjrobens1500242git

Good luck!

jrobens’s picture

jrobens commented

OK - created new branch and removed licence file.

coder review does come up clean for this.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

jrobens’s picture

jrobens commented

Been maintaining this in our own GIT repository. If someone shows interest we will provide an updated version.