Issues with ajax file upload fields

There's already code to make sure we don't try to capture values while in ajax, in entityreference_prepopulate_field_attach_form():

It seems to work for me on my use case, so I'll need more info / patch

Confirmed that I have the same issue. Any ideas so far?

Thanks guys!

Any progress on this? I would appreciate some help and am willing to pay for a patch to get this working.

Thank you!

So it appears that entityreference_prepopulate_field_default_value() was being called during the ajax submission step, but not called again on the "real" form submission. The empty value from the AJAX step was being cached, resulting in the field being empty on submission.

This patch sets $form_state['no_cache'] = TRUE in the AJAX step so that the form is rebuilt on submission. Patch is against 7.x-1.x.

Testbot, wake up!

I've installed the latest dev version and am still having the same issue.

@gthing , Please re-test using latest dev from GIT (as Drupal might not have packaged the fix in the new dev yet)

Amitaibu, I'm unable to test today but $form_state['rebuild'] = TRUE may not work -- see the form_set_cache() call here:
http://api.drupal.org/api/drupal/includes%21form.inc/function/drupal_reb...

Confirmed working. Thanks!

Howdy, I've been able to duplicate this issue on my installation. I'll let you know if I figure out a solution.

But don't be discouraged by that @ezheidtmann :)

I was able to get this to work using the latest version (1.1). It seems that the "do nothing" setting on the field is now working properly and the entity referenced is populated properly (in my case it is an Organic Group).

Hope this helps.

AJAX file upload needs cached form state in order to work - see ajax_get_form(); what #8 achieves is that it simply pulls data cached earlier during the initial build.
(If you move $form_state['no_cache'] = TRUE line outside of if statement, file upload will stop working altogether as there will be no cached data for this form_build_id at all.)

As for the original issue, I was unable to reproduce it on a clean install, using entityreference_prepopulate 7.x-1.1 and core Image field; hence, there probably are missing pieces in this puzzle. Someone who has had this issue might want to try reproducing it on a clean install and then adding modules one-by-one until you get it.

I've done some more testing and it looks like the original issue show up only if you set the pre-populate field to "hide." Setting it to "do nothing" makes it work as expected. Rolling back to 7.x-1.1 fixed the issue raised in #19.

In my case I would like to hide the field, but I supposed I could do that in CSS.

If anyone can reproduce the bug with that tidbit I'll still offer the bounty because it would be cool to have this bug fixed.

Hi Drave Robber,

I was able to reproduce the original issue with just ctools, entity, entityreference, and entityreference_prepopulate in addition to core. To the default "article" content type, I added a file attachment field and an entityreference field with entity type set to "node". I will try to reproduce with the latest HEAD if I have time today.

@Drave Robber: Thanks a lot! Finally able to reproduce...

Please find attached a patch fixing this issue. (Patch against 7.x-1.1, as I understood 7.x-dev introduced another bug, cf @gthing)

The issue was that on form rebuild on AJAX, #access was set back to true (while it was set to false on this bug use case (field hidden)), and my guess is that subsequentely it asks again for the default value, and the $_GET arg being not here, we end up with an empty value.
I must admit I don't have the full logical explanation on why it works now, I just did that in an hurry last half hour ;)
It also keeps on working in the field-not-required scenario.

Enjoy!

Tested. Still having the original issue with field required and set to hide.

@MEsch ,
Thanks for working on this.

(I chose sessions, but you could just as easily use the db) there.

I think it's best to use the $form_state itself in the after build, and then in entityreference_prepopulate_get_values_from_url() call ajax_get_form() if we are inside an AJAX request.

Minor: you have trailing spaces (use Dreditor to see them).

@MEsch, thanks for writing that. I'm going to re-write to use form_state and test. Stay tuned!

Does #35 this patch 1.1 or should I apply it to the previously patched module?

I couldn't get it to apply to 1.1, 7x-dev, or the previously patched module.

@MEsch

Tested against 1.1 and found it working in all of the above use cases. Huzzah!

PM me your paypal address

#43 works for me!

#43 works fine on 7.x-1.1 version and with a required ER field. Thanks

Looks like there are two approaches being worked on in parallel here. Both patches need work, though. The one in #49 doesn't apply to 7.x-dev and seems to require that $langcode be passed to the edited function, and the patch in #43 has coding style issues.

I'm not sure which approach is conceptually better, though.

Why do you set a default vale for langcode? Anyway it should be LANGUAGE_NONE, not 'und'

Missing dot in end of line. Also would be nice to have more comments about what the problem is and why we chose to solve it like this.

better surround this with an !empty() to prevent notices. It seems pretty fragile. At this state won't we get the default value in the $form_state?

I'll be working on this.

Please let me know if it works for you.

@a.ross, Thanks for the good review. I've attached also the interdiff.

> Also, the patches have so far haven't addressed AJAX requests using GET, as rare as that might be.

That's indeed sounds pretty rare -- I know Views for example changes $form['#method'] = 'get' on it's exposed filters, but that's not the case when submitting a new entity. Anyway, I think it's ok if it will be a follow-up patch if needed.

The last submitted patch, entityreference_prepopulate_ajax_submission-1502972-61.patch, failed testing.

Haven't tested, but from review:

I like this approach :)

Remove

Don't return here, just assign it to $ids -- to let it be processed along the function

Also make sure ti create a diff that can be applied (git diff)

Working on it

Alright, I get it. Here's a patch that fixes that issue. I had to restructure the if clauses a bit, I think I got it right, but please do review.

One thing though -- do we really need to get the form back out of cache?

I have some custom prepopulation code for another part of the same form, which is also affected by this problem, and what seems to be working is putting it in the $form_state when I can find it in the URL, and then just retrieving it from that next time around.

I'm currently hiding the file upload button so that files don't get Ajax-uploaded. Works as a temp fix but would appreciate a patched release.

@Amitaibu, do you think this is this ready to go in?

I getting error with the latest DEV could it be related to this patch ?

Hi, for some reason this exact issue still happens for me when working from latest dev. With the entity ref field set to hide when populated via URL if I test it without submitting an ajax file upload it works fine, if I try with a file upload via ajax it fails. Key difference for me possibly is that this is field is an OG group audience ref.

Also getting this error when trying to create an og group node that where the group audience field is prepopulated via the url, and the field is set to be hidden. 1.2 does not have this problem.

It appears to me that the error is occurring on content that doesn't have an ajax load now. All content types with a load are working.

the only thing i notice is for user who has not admin permision it loop back again on my side

It does a loop has describe at the top of the issue and a message appear saying that no item has been selected and i must select on value to continue.

#75 is not mine but the error i was getting in #78 and with the DEV is solve by your patch for my admin.

On another side the users who only have permission to creates nodes have the same problem describe before the latest dev version. it does a loop. After that if i select the reference manually it work. But when it is prepopulate it does not work.

Not for that node creation. On another section of the site yes but not for that.

Field title: Gallery
Fiel name: field_gallery_entityreference
Entity Reference
Select list

The Entity reference prepopulate checkbox is mark and the field is on disable. Apply action is not mark. Fall back is to do nothing and the permission for the skip access is set to Administer content. Og context none.

I also have a view to generate the list of entity and restrict to the entity the user and only the user have access. If you want acces to my dev site just let me know in private message. maybe it could be easy that way for you.

In general i'm using Upload Nodes (sandbox) to upload multiple images into a gallery. Without prepopulate module everything work great. Just let me know if you want a copy of the module or have another question or test to do.

The patch in 85 gets things working for me with an OG group audience field set to prepopulate from the URL, on a content type that does *not* have any kind of ajax field.

@Sw3b I can't reproduce the problem you're having with those settings. It would seem likely that there is a conflict with the other module you mentioned. And since it's a sandbox project I don't think we can do a lot about that issue.

@tjhart, the patch included both.

@Amitaibu, the reason I used empty() instead of an implicit cast to boolean, is that the cast will cause a notice when the variable is undefined, which was what was happening here. This should do it:

Please don't bump the priority -_-

#102: entityreference_prepopulate_ajax_submission-1502972-102.patch queued for re-testing.

The last submitted patch, entityreference_prepopulate_ajax_submission-1502972-102.patch, failed testing.

haha thanks smarty. Wasn't paying attention.

What a morning without coffee? :)

Alright, I have been able to reproduce the problem. What happens here is that when the form is submitted, a POST request is sent, containing the form_build_id. The prepopulate values are available in the $_GET superglobal as usual, though, so no need to get it from the form_state. In fact, when we try to get the form out of cache in this case, it's empty! So that's where the problem arises. Attached is a proper fix. I also added a bit of documentation to make it clear what the various if/else constructs mean. I also took the liberty to correct an unclear sentence (the last line in the diff), sorry about that.

The last submitted patch, entityreference_prepopulate_ajax_submission-1502972-114.patch, failed testing.

The last submitted patch, entityreference_prepopulate_ajax_submission-1502972-115.patch, failed testing.

I have checked #119 patch.

After submitting entity with entityreference_prepopulate field I am getting next message: Field Plan Document must be populated via URL. PHP notice gone.

On create page field works great. I mean disable or hide actions work.

Alright, good news! Thanks for testing

We are having issues applying the patch to the 7x 1.2 branch. Will this patch work there or is it specifically for dev?

We finally were able to apply the patch manually. Since we hadn't followed the sequence of previous patches it was getting rejected. Test look good so far. Thanks a.ross

bump

Can this be committed? 3 people have tested the patch, including me, and there haven't been any problems yet. Thanks

Hi,
the patch works great. But it's missing the code to make it work when "og context" option is active.
I have a file/image upload form in a group panel page, so I use og_context to prepopulate.
I've created a small patch, I'll upload it to review (probably needs refactoring).

I can't really dive into this because I've got a deadline to meet and we're not using OG, so it'd cost me a bit more time than usual. But the patch looks ok at first sight.

I do some debugging and found the problem in the following function:

When i remove the part with the check if (empty($instance['field_mode'])) it works:

When I upload the image in the node, the function is called with a field_mode default, when i save the node after upload, the function entityreference_prepopulate_og_field_default_value() is called again but field_mode is not set.

I hope this information helps to fix the problem.

Same as tatyana — latest dev and patch from #130 did not solve the problem. If I comment out the lines referenced in #134 (which obviously the commenter is not suggesting as a solution, but I thought I'd try it to see what happens), the entityreference field does retain the group reference.

However, I'm using Auto Nodetitle to pull the group name into the content title, and with this configuration the group name does not get pulled through into the title, so I get the token instead (e.g., my title is "[node:field-organization] 2012-13 Project Application"). If I don't upload a file, then the auto nodetitle works fine.