While commit and tag messages could contain a magic string like ENDOFOUTPUTGITMESSAGEHERE they can't contain \0. We should probably use that as a delimiter.

CommentFileSizeAuthor
#1 1502978-magic-delimiter-1.patch2.5 KBNiklas Fiekas

Comments

Niklas Fiekas’s picture

Niklas Fiekas commented
Status: Active » Needs review
StatusFileSize
new 1502978-magic-delimiter-1.patch2.5 KB

Untested: https://github.com/niklasf/versioncontrol_git/commit/0f0fb7964e5c4fd9d24...

sdboyer’s picture

sdboyer commented

i hate that delimiter as well, and i experimented with this very idea myself. what worried me about it was the way that PHP, being C-based, handles nul bytes. i can't remember what i came to, but we've got tests that verify this stuff now, so...let's try it :)