Needs review
Project:
Omega
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
26 Mar 2012 at 17:43 UTC
Updated:
21 May 2015 at 21:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
marcoka commentedComment #2
dboudreau commentedTwo quick CSS fixes that could be added here would be:
I'm happy to help with both today.
Comment #3
sylvain_a commentedI've been working with Denis today and i'll be able to do a follow-up on it.
(Ideally a patch, or at least the exact CSS code suggested.)
Comment #4
sylvain_a commentedIndeed, an outline is needed on focusable elements for accessibility reasons.
It seems that the actual behaviour could be traced back to the use of Eric Meyer's "reset.css", with its recognizable "remember to define focus styles" comment. A quick and precise rationale is available here:
http://www.outlinenone.com/
This could be corrected by replacing this part in "alpha/alpha-reset.css":
with
Comment #5
sylvain_a commentedAlternatively, on the long term, using normalize.css could be an option, to replace the original reset.css.
Here is what normalize.css offers as best practices for outlines, after thorough experimentation:
Comment #6
sylvain_a commentedAs a themer, I'm not really familiar with patches, but here is what a patch could look like. Please review (using branch 7.x-3,x).
Comment #7
mgiffordThanks sylvain!
Comment #8
cellar door commentedSeems reasonable to me... himerus what do you think of this for a 3.2 inclusion?
Comment #9
cellar door commentedJust saw on the 3.2 roadmap. I'll put it as ready to be patched since it's a one liner that won't crash anything
Comment #10
damienmckennaI believe "Needs review" is the correct status, given someone uploaded a patch.
Comment #11
mgiffordAgreed! And it still applies in SimplyTest.me even though it is 3 years old.