Allow for custom usernames and ports on remote connections

This is actually a provision bug: #1504120: Script user of remote servers is ignored

Once that provision issue is fixed, we should present an option in the UI to change the script user on the remote server.

So I fixed the upstream bug, so we should be able to support this in Aegir 1.9 and above.

This would be handy for moving from a Barracuda to an Octopus install.

Might it be possible to add a field for a non-standard SSH port also?

moving....

Incorporating #4.

Hi,
I'm using some servers with differents usernames (o1, o2, dev1,...),
so i have made a patch to choose a custom username on server config page.

See attached file.

Thanks for looking into this.

+++ b/drush/Provision/Service/remote/import/hostmaster.php
@@ -121,7 +129,14 @@ class Provision_Service_remote_import_hostmaster extends Provision_Service_remot
+    if (isset($this->server->remote_user)) {

These should probably be empty() instead of isset(). When you clear the new field it would otherwise use an empty string as username.

Yes, you're right.

I've replaced "isset" by "!empty" to avoid an empty string as username.

I haven't tested this, but I took a quick look at the code. Yes, thanks for working on this.

+++ b/hosting_remote_import.service.inc
@@ -25,6 +25,61 @@ class hostingService_remote_import_hostmaster extends hostingService_remote_impo
+  ¶
...
+  ¶
+  ¶
...
+  ¶
...
+  ¶
...
+  ¶
...
+  ¶
...
+  ¶

Extra whitespace is appearing on these blank lines. (8 lines from 29 to 84.)

+++ b/hosting_remote_import.service.inc
@@ -25,6 +25,61 @@ class hostingService_remote_import_hostmaster extends hostingService_remote_impo
+      );

Bad indentation.

New patch (v3.10)

Apart from the two trivial updates below it looks sane, but I haven't got time to test it properly.
@colan, can we get it rtbc by Thursday? Then I can include it it 3.11

1. +++ b/hosting_remote_import.service.inc
   @@ -26,5 +26,59 @@ class hostingService_remote_import_hostmaster extends hostingService_remote_impo
   +  ¶
   

   whitespace bug

2. +++ b/hosting_remote_import.service.inc
   @@ -26,5 +26,59 @@ class hostingService_remote_import_hostmaster extends hostingService_remote_impo
   +    drush_log("context_options " . print_r($task,1));
   

   debug?

If there's a new patch available shortly, I should be able to test it by then (at least ensuring that it doesn't break anything).

Fixed coding standards violations. See interdiff for details.

As this doesn't appear to break existing functionality, I committed it.

Set status back so we can work on adding support for custom ports (or any follow-up commits if the new functionality needs tweaking).

Custom ports would be handy, and a bit more secure. For me, remote imports is a very helpful (when migrating to a new server, for example) but not every day. So, I just switch my SSH server back to port 22 for the imports and return to a custom port when I'm done.

Thanks for all the fish!