This project creates installments for Commerce orders. One can add, edit, delete and pay installments. Installments are written with using entity api. Installments are supported by views and one can get detailed reports about installments.
http://drupalcode.org/sandbox/zulfierken/1502028.git
This is a drupal 7 project.
Prject link : http://drupal.org/sandbox/zulfierken/1502028
I added the zipped module if there was a problem in git

CommentFileSizeAuthor
commerce_order_installment.zip72.34 KBzulfierken

Comments

adammalone’s picture

adammalone
Primary language English
Location San Francisco
commented
Status: Active » Needs work

You can find the result of the autoreview at this URL: http://ventral.org/pareview/httpgitdrupalorgsandboxzulfierken1502028git

The main issues reported are:

  • CVS $Id tags aren't used anymore, you can remove them.
  • There are a number of indentation issues that just need fixing
  • Use spaces to indent not tabs
  • Concatenation operators must be surrounded by spaces
  • Class names must use UpperCamelCase where the first letter of each word is in caps

When you've corrected all the coding standards issues and pushed your changes simply set the tag to 'needs review' and the application can proceed.

zulfierken’s picture

zulfierken commented
Status: Needs work » Needs review

I committed with changing codes

jpontani’s picture

jpontani commented
Status: Needs review » Needs work

You still have a substantial amount of coding style issues to fix.

Your branch should be named "7.x-1.x", not 7.x-1.x-dev. See Moving from a master to a major version branch.

Also, your repo base directory should be inside your module, it should not include the "commerce_order_installment" directory.

sokrplare’s picture

sokrplare commented

Love the idea for this module, but looks like a lot of client-specific code still included (ie school fees related code). That should ideally be cleared out too so this can be generic and not specifically for a school tuition system.

Would love to see this become a full project!

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented

Just spent 30 minutes looking for this sandbox... @jpontani pointed me in the right direction. Multiple Payments in Drupal Commerce are something that was considered very difficult by @rszrama: http://drupal.org/node/1096504

I can assure you the idea of this module is very needed in the community. I'll see if we can rally a bit more coding support.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.