This is a light weight module. This is developed in consideration with adding vocabulary images. In some cases your project( E-commerce site) needs to display list of vocabularies with their images.
One of my project needs to same feature. I searched a lot but not found any solution. Then after all I decided to write their own module and also wants it to contribute. So it can provide some help to reach at appropriate solution for this type of listing.
Sandbox link - http://drupal.org/sandbox/brajendrasingh/1386558
Drupal core version - (7.x)

Comments

zpieslak’s picture

zpieslak commented
Status: Needs review » Needs work

Hi brajendrasingh,

This is very nice module ;)

Some very small issues I found in your module:
- README file has to have max 80 characters per line
- You should read Drupal Coding Standards part about indentation:
http://drupal.org/coding-standards#indenting

As a feature requests:
- It would be nice to have some theme function - not every user can know the vid of the vocabulary to use your function "_get_vocab_image_path($vid)"
- It would be very nice to have views integration

anwar_max’s picture

anwar_max
Primary language English
commented

Hi Brajendra,

Please take a moment to make your project page follow tips for a great project page.
Please see result of automated review from ventral pareview and try to fix errors and warnings.
On the link, you should "repeat review" before change back status of the task to "need review".

Manual Code Review:

README.txt
1) If a line has more than 80 characters then wrap your text.

vocabulary_image.admin.inc
1) Every text display to users should be in t() function as in vocabulary_image.admin.inc. Like on line 24 '#description' => 'Separate extensions with a space or comma and do not include the leading dot.',
2) Remove unnecessary comments as at line 34 and 57 in vocabulary_image.admin.inc.
3) Every comments should end by a "." , "?" or "!".
4) Use proper indention.

I think you should use coder module it will give you the all information related to the coding standards.

soncco’s picture

soncco commented

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

brajendrasingh’s picture

brajendrasingh commented

Hi zpieslak,

Thanks for your review. Feature request which you suggested for theme function is good, but for using this they also need to know the theme function. "_get_vocab_image_path($vid)" will be rarely used only for getting vocab image as per requirement accomplished by code.
Vocabulary image details will be rendered by loading vocabulary info with the use of "taxonomy_vocabulary_load()".
I am working on views integration for this module.

Thanks,
Brajendra Singh

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.