Closed (fixed)
Project:
Drupal.org Library Packaging Allowlist
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
27 Mar 2012 at 07:04 UTC
Updated:
12 Jan 2016 at 03:04 UTC
Jump to comment: Most recent
Comments
Comment #1
dwwFrom http://twig.sensiolabs.org --
http://twig.sensiolabs.org/license for more details.
https://github.com/fabpot/Twig/tarball/v1.6.3 is 145Kb, the extracted directory structure is just over 2Mb.
Clearly a lot of interest in Twig these days, so it makes sense to allow this. I'll let the actual whitelist maintainers confirm and actually create the whitelist node...
Comment #2
rene bakxThank you for your quick answer :)
Comment #3
geerlingguy commentedAdded: http://drupal.org/node/1504506 (I'm assuming by 'new BSD' they mean 'modified BSD'... at least that's what it looks like to me).
Comment #5
lee20 commentedCurious to know why the "fabpot" fork of Twig (https://github.com/fabpot/Twig) was selected for whitelisting instead of the primary repository at: https://github.com/twigphp/Twig
Is there an explanation for this or can we add the twigphp/Twig repository to the whitelist as well?
Thanks!
Edit: I should have mentioned that the twigphp has tags that are not available on the fabpot fork. I have been testing with newer tags provided by the twigphp repo so it will save me time retesting on older tags if we can add this to the whitelist.
Comment #6
geerlingguy commentedDefinitely—we'll need to keep support for fabpot's fork since some profiles may be using it, but we should add in the official repo.
Comment #7
lee20 commentedAwesome! Thanks for the quick response.
Here is the regex depending on whether you want to modify the existing whitelist node (http://drupal.org/node/1504506) or add another one.
For a new whitelist node:
To add twigphp to existing whitelist for twig:
I haven't tested these but they should be pretty straight forward.
Comment #8
geerlingguy commentedUpdated the old node: https://www.drupal.org/node/1504506