Besides the Symfony components it would be very handy to have Twig on the whitelist as wel.

So It's easier to create a distribution for http://drupal.org/node/1499460 instead of having to pass around a pre-assembled drupal 7.

Comments

dww’s picture

Status: Active » Reviewed & tested by the community

From http://twig.sensiolabs.org --

Twig is released under the new BSD license.

http://twig.sensiolabs.org/license for more details.

https://github.com/fabpot/Twig/tarball/v1.6.3 is 145Kb, the extracted directory structure is just over 2Mb.

Clearly a lot of interest in Twig these days, so it makes sense to allow this. I'll let the actual whitelist maintainers confirm and actually create the whitelist node...

Rene Bakx’s picture

Thank you for your quick answer :)

geerlingguy’s picture

Status: Reviewed & tested by the community » Fixed

Added: http://drupal.org/node/1504506 (I'm assuming by 'new BSD' they mean 'modified BSD'... at least that's what it looks like to me).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

lee20’s picture

Issue summary: View changes
Status: Closed (fixed) » Needs work

Curious to know why the "fabpot" fork of Twig (https://github.com/fabpot/Twig) was selected for whitelisting instead of the primary repository at: https://github.com/twigphp/Twig

Is there an explanation for this or can we add the twigphp/Twig repository to the whitelist as well?

Thanks!

Edit: I should have mentioned that the twigphp has tags that are not available on the fabpot fork. I have been testing with newer tags provided by the twigphp repo so it will save me time retesting on older tags if we can add this to the whitelist.

geerlingguy’s picture

Status: Needs work » Reviewed & tested by the community

Definitely—we'll need to keep support for fabpot's fork since some profiles may be using it, but we should add in the official repo.

lee20’s picture

Awesome! Thanks for the quick response.

Here is the regex depending on whether you want to modify the existing whitelist node (http://drupal.org/node/1504506) or add another one.

For a new whitelist node:

^(git|https|http)://github\.com/twigphp/Twig[.git/].+$
^(https|http)://raw.githubusercontent\.com/twigphp/Twig/.+$
^(https|http)://codeload.github.com/twigphp/Twig/.+$

To add twigphp to existing whitelist for twig:

^(git|https|http)://github\.com/(fabpot|twigphp)/Twig[.git/].+$
^(https|http)://raw.githubusercontent\.com/(fabpot|twigphp)/Twig/.+$
^(https|http)://codeload.github.com/(fabpot|twigphp)/Twig/.+$

I haven't tested these but they should be pretty straight forward.

geerlingguy’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.