It didn't save endpoint field label.

Errors:
Notice: Trying to get property of non-object in relation_endpoint_field_validate() (line 28 of sites/all/modules/contrib/relation/relation_endpoint.module).
Notice: Trying to get property of non-object in relation_endpoint_field_validate() (line 34 of sites/all/modules/contrib/relation/relation_endpoint.module).
Notice: Undefined variable: delta in relation_endpoint_field_validate() (line 32 of sites/all/modules/contrib/relation/relation_endpoint.module).
Notice: Trying to get property of non-object in relation_endpoint_field_validate() (line 39 of sites/all/modules/contrib/relation/relation_endpoint.module).
Notice: Trying to get property of non-object in relation_endpoint_field_validate() (line 49 of sites/all/modules/contrib/relation/relation_endpoint.module).
Notice: Trying to get property of non-object in relation_endpoint_field_validate() (line 55 of sites/all/modules/contrib/relation/relation_endpoint.module).
relation_nonexistent_type

CommentFileSizeAuthor
#12 1504046-12.patch1.5 KBmikran
#11 issue-1504046-11.patch1.7 KBmr.york
#9 6052546_9.patch1.22 KBchx
#7 tests-1504046-7.patch1.23 KBmikran
#3 Issue-1504046.jpg175.88 KBmr.york
#1 issue-1504046-1-It_didn_t_save_endpoint_field_label.patch571 bytesmr.york

Comments

mr.york’s picture

mr.york commented
Status: Active » Needs review
StatusFileSize
new issue-1504046-1-It_didn_t_save_endpoint_field_label.patch571 bytes

This patch is simple bugfix.

mikran’s picture

mikran commented

What exactly were you attempting to do when the error occured?

mr.york’s picture

mr.york commented
StatusFileSize
new Issue-1504046.jpg175.88 KB

Path is admin/structure/relation/manage/[relation_type]/fields/endpoints

mikran’s picture

mikran commented
Status: Needs review » Reviewed & tested by the community

Well, since it's not possible to provide any default values for relation endpoints the patch is ok.

chx’s picture

chx commented
Status: Reviewed & tested by the community » Needs work

No. What you want is a no ui in the field definition. Why the field is on the UI? I thought we added no ui long ago.

chx’s picture

chx commented
Issue tags: +Needs tests

Ok scratch #5 but still.

mikran’s picture

mikran commented
Status: Needs work » Needs review
StatusFileSize
new tests-1504046-7.patch1.23 KB

My first shot at writing Drupal tests

chx’s picture

chx commented

That's one interesting patch, 'cos I do not have a test called testRelationImport.

chx’s picture

chx commented
StatusFileSize
new 6052546_9.patch1.22 KB

Here's a reroll. I am not going to commit this yet because the test needs to a) use a random label b) check that label actually got saved not just messaged about it. Thanks for the patch so far!

mikran’s picture

mikran commented
Assigned: mr.york » mikran
Status: Needs review » Needs work

testRelationImport was missing with the relation_ui files.

mr.york’s picture

mr.york commented
Status: Needs work » Needs review
StatusFileSize
new issue-1504046-11.patch1.7 KB

I moved test in relation_ui.test file and add randomName label check.

mikran’s picture

mikran commented
StatusFileSize
new 1504046-12.patch1.5 KB

Thanks mr.york, I modified the test a bit. I'll commit if this passes testbot

mikran’s picture

mikran commented
Status: Needs review » Fixed

and committed.

Automatically closed -- issue fixed for 2 weeks with no activity.