usage of uc_simple_quote broke ajax operations in checkout pane (with fix) [#1504174]

When uc_simple_quote got activated displayed in the checkout page of my installation, the return data of the first of the following ajax operations got styled as if it was a complete node, e.g. inside a complete div id="page", content, content-inner and so on. Deactivated display in the checkout page, and the problem was gone. I eventually found out it had something to to with the foreach loop on line 37 of uc_simple_quote.module:

        foreach ($node as $key => $value) {
          if (!isset($product->$key)) {
            $product->$key = $value;
         }
      }

The following call of uc_order_get_total() really only needs the keys price and qty, so I changed the loop accordingly:

        foreach ($node as $key => $value) {
          if ($key == 'price' or $key == 'qty') {
                $product->$key = $value;
          }
        }

This fixed the issue.

My installation:

Drupal 6.25
Ubercart 6.x-2.7
uc_simple_quote 6.x-1.0
The theme used is built on top of Fusion Core 6.x-1.12

Comments

Comment #1

velpan CreditAttribution: velpan commented 5 April 2012 at 23:25

This fix didn't work for me.

Can you check it once more?

Comment #2

velpan CreditAttribution: velpan commented 6 April 2012 at 00:33

Finally it worked when I insert some more fields

<?php
       foreach ($node as $key => $value) {
          if (!isset($product->$key)) {
			if (in_array($key, array('qty','price','shippable','shipping_type','shipping_address'))) {       
             $product->$key = $value;
			} 
          }
        }
?>