JS error when the ckeditor module is installed, and no ckeditor present [#1504302]

Hello,

In a configuration with the modules 'maxlength' and 'ckeditor' installed, and in an node edit page without a ckeditor, I get a JS error: 'CKEDITOR not defined' because of the following code:

  ml.ckeditor = function() {
    // We only run it once
    var onlyOnce = false;
    if (!onlyOnce) {
      onlyOnce = true;
      CKEDITOR.on('instanceReady', function(e) {

which is called on the condition:

      } else if (Drupal.settings.ckeditor != undefined) {

which checks that the module 'ckeditor' is installed, but not that ckeditor is actually initialized on the page.

The patch to fix this will follow.

Comment	File	Size	Author
#8	maxlength-js-error-no-ckeditor-1504302-8.patch	381 bytes	dasjo
#1	maxlength-js-error-no-ckeditor-1504302.patch	381 bytes	ndeschildre

Comments

Comment #1

ndeschildre commented 27 March 2012 at 11:30

Status:

Active

» Needs review

Status	File	Size
new	maxlength-js-error-no-ckeditor-1504302.patch	381 bytes

Please find attached the patch.

--- a/js/maxlength.js
+++ b/js/maxlength.js
@@ -13,7 +13,7 @@
             ml[editor]();
           }
         });
-      } else if (Drupal.settings.ckeditor != undefined) {
+      } else if (Drupal.settings.ckeditor != undefined && typeof(CKEDITOR) !== 'undefined') {
         ml.ckeditor();
       }

Comment #2

rooby commented 4 June 2012 at 23:20

Priority:	Normal	» Major
Status:	Needs review	» Reviewed & tested by the community

This also happens on my site.

It is more of an issue because it breaks other javascript on the page and things don't work properly.

The patch fixes it for me and looks good so setting RTBC to maybe get someone else's eyes on it.

Comment #3

mvwensen commented 23 November 2012 at 11:30

Fix also works on 7.x-3.0-beta1 after changing (manually)

Comment #4

dawehner

German

commented 4 December 2012 at 16:38

What about adding a small comment why we are doing that here? Just as a random guy i wouldn't know what is going on :)

Comment #5

drclaw commented 28 February 2013 at 02:09

This patch also worked for me (manually applied). Thanks!

To help other people searching this issue: I needed this because the maxlength was giving an error Uncaught ReferenceError: CKEDITOR is not defined. This was because even though I had CKEDITOR installed, it wasn't being used on my field which was using the "Plain Text" text format.