Currently, the code does not meet the drupal coding standards. See http://drupal.org/node/1354 and http://drupal.org/coding-standards. This should be fixed.

Original issue description:
Coder module highlighted a few areas which need addressing, like strings not being run through t() and some style issues. The attached patch corrects those issues.

CommentFileSizeAuthor
protected_node-d7_code_cleanup.patch5.92 KBbarrett

Comments

zilverdistel’s picture

zilverdistel commented
Status: Needs review » Needs work

Hi Barrett,

The patch looks good but it does not apply to the latest git. Can you please reroll? Also, there's more work on this than the changes included by the patch. A lot of comments do not follow the code standards (Inline comments should start with a capital and end with a period or other punctuation mark. Comments cannot exceed the 80 characters on a line limit. Probably more things to be fixed ...).

Thank you,

Diederik

zilverdistel’s picture

zilverdistel commented
Title: Clean up code based on Coder module output » Clean up code so it meets the Drupal coding standards
Category: bug » task
zilverdistel’s picture

zilverdistel commented
Status: Needs work » Closed (fixed)

Committed: http://drupalcode.org/project/protected_node.git/commit/431611d

zilverdistel’s picture

zilverdistel commented
Issue summary: View changes

Updated issue summary.