Ater sending mail I have a warnings (see screenshot).

I use theme based on "Pixture Reloaded".
And 7.x-2.33 version of "Mail System" module.

I found this bug into template_preprocess_mimemail_message() function.
It because this function does not correct $css_files array for drupal_get_css();

CommentFileSizeAuthor
#7 mimemail-fix_for_warnings-1504782.patch1.35 KBrjkuyvenhoven
#1 0001-Warnings-after-sending-the-letter.patch1.11 KBmrded
Screen Shot 2012-03-28 at 00.23.14.PNG30 KBmrded

Comments

mrded’s picture

mrded commented
Status: Active » Needs review
StatusFileSize
new 0001-Warnings-after-sending-the-letter.patch1.11 KB

Please check my patch.

sgabe’s picture

sgabe commented

This patch seems to wipe out a feature to get rid of an error message, but it does not seem to be a fix for the issue. Did you test it with a Fusion based theme? Are these lines unnecessary on Drupal 7?

mrded’s picture

mrded commented

No I did't test it on on Fusion theme. I think it's unnecessary code because it have wrong structure.

sgabe’s picture

sgabe commented
Status: Needs review » Needs work

Wrong structure does not mean that it is unnecessary, it just means it is wrong.

mrded’s picture

mrded commented

Yes, definitely. Sorry :)

sgabe’s picture

sgabe commented
Issue tags: -mimemail, -drupal 7, -warnings

#1526754: Multiple Errors after subscription is marked as a duplicate of this.

rjkuyvenhoven’s picture

rjkuyvenhoven commented
StatusFileSize
new mimemail-fix_for_warnings-1504782.patch1.35 KB

this patch modifies the code to use drupal_add_css() to load local.css file if it exists.

sgabe’s picture

sgabe commented
Title: Warnings after sending the letter » Update support for Fusion based themes
Status: Needs work » Fixed

Thanks rjkuyvenhoven, your patch is committed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

sourcesoft’s picture

sourcesoft commented

Just want to add text errors to make it easier goggling since I had a day debugging this :( I got this using zen sub-theme.
Beside the patch working alright, also got fixed after unchecking ' Include site style sheets' setting

Notice: Undefined index: group in drupal_sort_css_js() (line 3025 of common.inc).
Notice: Undefined index: group in drupal_sort_css_js() (line 3025 of common.inc).
Notice: Undefined index: group in drupal_sort_css_js() (line 3028 of common.inc).
Notice: Undefined index: group in drupal_sort_css_js() (line 3025 of common.inc).
Warning: uasort() [function.uasort]: Array was modified by the user comparison function in drupal_get_css() (line 2970 of /common.inc).
Notice: Undefined index: type in drupal_get_css() (line 2975 of /home/common.inc).
Warning: ksort() expects parameter 1 to be array, null given in drupal_group_css() (line 3102 of common.inc).
Notice: Undefined index: type in drupal_group_css() (line 3114 of common.inc).
Notice: Undefined variable: group_keys in drupal_group_css() (line 3134 of common.inc).
Notice: Undefined index: type in drupal_aggregate_css() (line 3175 of common.inc).
Notice: Undefined index: type in drupal_pre_render_styles() (line 3295 of common.inc).