Download & Extend

Update support for Fusion based themes

Project:Mime Mail
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Ater sending mail I have a warnings (see screenshot).

I use theme based on "Pixture Reloaded".
And 7.x-2.33 version of "Mail System" module.

I found this bug into template_preprocess_mimemail_message() function.
It because this function does not correct $css_files array for drupal_get_css();

AttachmentSize
Screen Shot 2012-03-28 at 00.23.14.PNG30 KB

Comments

#1

Status:active» needs review

Please check my patch.

AttachmentSize
0001-Warnings-after-sending-the-letter.patch 1.11 KB

#2

This patch seems to wipe out a feature to get rid of an error message, but it does not seem to be a fix for the issue. Did you test it with a Fusion based theme? Are these lines unnecessary on Drupal 7?

#3

No I did't test it on on Fusion theme. I think it's unnecessary code because it have wrong structure.

#4

Status:needs review» needs work

Wrong structure does not mean that it is unnecessary, it just means it is wrong.

#5

Yes, definitely. Sorry :)

#6

#1526754: Multiple Errors after subscription is marked as a duplicate of this.

#7

this patch modifies the code to use drupal_add_css() to load local.css file if it exists.

AttachmentSize
mimemail-fix_for_warnings-1504782.patch 1.35 KB

#8

Title:Warnings after sending the letter» Update support for Fusion based themes
Status:needs work» fixed

Thanks rjkuyvenhoven, your patch is committed!

#9

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#10

Just want to add text errors to make it easier goggling since I had a day debugging this :( I got this using zen sub-theme.
Beside the patch working alright, also got fixed after unchecking ' Include site style sheets' setting

Notice: Undefined index: group in drupal_sort_css_js() (line 3025 of common.inc).
Notice: Undefined index: group in drupal_sort_css_js() (line 3025 of common.inc).
Notice: Undefined index: group in drupal_sort_css_js() (line 3028 of common.inc).
Notice: Undefined index: group in drupal_sort_css_js() (line 3025 of common.inc).
Warning: uasort() [function.uasort]: Array was modified by the user comparison function in drupal_get_css() (line 2970 of /common.inc).
Notice: Undefined index: type in drupal_get_css() (line 2975 of /home/common.inc).
Warning: ksort() expects parameter 1 to be array, null given in drupal_group_css() (line 3102 of common.inc).
Notice: Undefined index: type in drupal_group_css() (line 3114 of common.inc).
Notice: Undefined variable: group_keys in drupal_group_css() (line 3134 of common.inc).
Notice: Undefined index: type in drupal_aggregate_css() (line 3175 of common.inc).
Notice: Undefined index: type in drupal_pre_render_styles() (line 3295 of common.inc).

nobody click here