Hi. I'm very interested in using this module but noticed that the D7 branch is in dev. What issues/tickets/cleanup are left preventing a stable release?

Comments

greggles’s picture

Yeah, good question :)

I think it needs a thorough review to confirm it works well with core and popular contribs to remove all places you can execute PHP. Were you able to test it?

rickmanelius’s picture

I haven't tested it yet but I will shortly as I'm doing a security audit for several clients. This is one of the modules I want to put in place for all of them, so I'll gladly test it.

Based on my current schedule and a more pressing need to update known areas, I probably won't get to this until monday/tuesday. But as soon as I'm done, I'll update this thread.

greggles’s picture

I'd like to add #1358612: Prevent granting permissions flagged as dangerous from being assigned to anonymous (and authenticated) users..

Once that's done I think it should basically be ready, so an RC1 for a while and then a 1.0 seem like the next steps.

rickmanelius’s picture

That sounds fine by me. I had a lot of PCI items to go through, so I haven't tested this yet. Tomorrow/Thursday are likely... And I'll also check out the other ticket in #3.

greggles’s picture

rc1 release coming up in http://drupal.org/node/1548164

rickmanelius’s picture

Hey @greggles.

I just did about 40 minutes of testing. Let me break my response into two areas: php execution protection and configuration protection.

I think the RC1 version does an excellent job on the php front. I was able to confirm that proper modules/filter are disabled.

The concerns I still have (and I'll break these into tickets) surround around configuration.

User's with 'Administer users' can still alter user#1's username. While this doesn't open the door for another admin to take over the account with a new password, it can block an admin from getting into the site without either altering this value in the db.

The instructions on the project page state "After installing, be sure to visit and save the permissions form to remove all previous grants." Should these steps take place in hook_install (and maybe hook_cron) or would that piss people off? In addition to this, you actually cannot remove those permissions through the admin GUI after they are hidden (I can confirm all php related permissions are still in the db). This has the surprising effect (or at least unexpected) of all those permissions returning if/when the module is disabled. I realize that with the php module disabled, this might be moot. But other modules that have hidden permissions not related to the php input filter (e.g. 'bypass rules access') would be available out of the gates again.

I know not allowing the module to be disabled through the GUI would prevent many of the above scenarios. But a user on the drush command line could slip and I'd rather a temporary disabling of the module to leave all those permissions still off just in case the admin didn't notice it being tripped off.

Next. It would be cool if user #1 could still see the permissions t hat are no longer alterable in the admin GUI form. Perhaps they are merely set to 'disabled' (e.g. greyed out) so they can't be changed but an admin still knows they were there but simply disabled by paranoia.

Finally, I'm really interested in the Two Factor Authentication module. Perhaps a module with a name like 'paranoia' would at least recommend such a module on hook_enable!

That's all from me. I'll break these into tickets. And short of some unexpected behavior, the module does work as claimed in my tests. Thanks for pushing this to RC status! And ping me if anything I mentioned isn't clear or (worse) is a bad idea :)

greggles’s picture

Preventing edit of uid 1 name seems like a good idea. Please do open that ticket.

I've updated http://drupal.org/node/1358612#comment-5923086 to take care of all the permissions ideas.

I think the project page and/or README should recommend other modules (or link to an article that recommends them). I can do that.

Thanks for testing!

rickmanelius’s picture

Cool. Ticket is here #1549542: Preventing edit of uid 1 name. I don't necessarily see it as a release blocker, but it would be nice for a 1.0 release.

I just need to remove my dependency on the php filter in a few areas and I'll be ready to use/install!

greggles’s picture

Status: Active » Fixed

Just created http://drupal.org/node/1802606

Thanks for the testing and feedback!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.