I do not think that we should have a default Flag installed on activation of the module, therefore we need to remove 'Bookmarks' flag from the module.

Comments

misc’s picture

Status: Active » Needs review
StatusFileSize
new12.2 KB

And here is the patch.

misc’s picture

StatusFileSize
new10.46 KB

Rerolled to work with commit d97949a81ce48c0ba9afcff8a6dd2c55352d4747

quicksketch’s picture

The bookmarks flag is a great learning tool for figuring out what Flag does and how to configure a view with Flag module. If you don't want the flag, you can easily delete it after installation.

misc’s picture

Yes it is a good way to learn how Flag works, but it is cluttering the interface - I think that something you should not want to be installed, should not be installed from the beginning.

I think the bookmarks flag should be a separate module, and only activated if you want to use it. If I have the time I do a patch for that later this week.

quicksketch’s picture

I would consider it the same thing as the standard profile of Drupal including article and page content types. Speaking from the point of view of the maintainer, increasing the learnability of the module improves user experience and speeds learning (thus reducing support requests).

Over in the Webform queue, we added an option that would disable the creation of the "Webform" content type if desired via a hidden variable (mostly for the purpose of install profiles). I'd be willing to do the same thing for Flag, effectively not changing the behavior for 99% of users and letting users who don't want it on install to skip it via a hidden variable. See #1263584: Option to *not* create the default Webform content type.

mattiasj’s picture

I agree that this default flag should be optional. It is quite confusing for clients and site builders to have a function that is not in use.

socketwench’s picture

David Reid had an excellent suggestion on how to move forward on this issue in #1699328: Move the bookmark flag to its own sub-module.

Status: Needs review » Needs work

The last submitted patch, remove_bookmarks-1506426-2.patch, failed testing.

joachim’s picture

Status: Needs work » Closed (duplicate)