According to google, an API key is no longer required to use google maps. But the gmap module still requires you to use an API key. Can we apply this patch to make the API key field optional to use?

CommentFileSizeAuthor
#4 gmap-remove-api-key-requirement-issue-1506434.patch1.38 KBkleve
gmap-remove-api-key-requirement.patch643 byteskleve

Comments

kleve’s picture

kleve commented
Title: Remove the mandatory API key field » Make the API key field optional
haiiro.shimeji’s picture

haiiro.shimeji commented
Status: Active » Needs review

Thanks, I tried this patch and it works fine.

but, I wonder you should make the patch in the gmap module directory.

$ cd sites/all/modules/gmap/
$ git diff > gmap-remove-api-key-requirement.patch

(to try this patch, add -p4 option to git apply command.



And I think the description for Google API key setting form should be change.
"You must get this for each separate website at Google Map API website." -> "??"

kleve’s picture

kleve commented

Yes, the description should also be changed.

kleve’s picture

kleve commented
StatusFileSize
new gmap-remove-api-key-requirement-issue-1506434.patch1.38 KB

Here is a new patch.

FAAREIA’s picture

FAAREIA commented

tested #4 patch, and it works fine =)
thanks for your work!

haiiro.shimeji’s picture

haiiro.shimeji commented
Status: Needs review » Reviewed & tested by the community

It works for me, too.
And thanks for change the description.

bdragon’s picture

bdragon commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Reviewed & tested by the community » Fixed

This made it in via merging haiiro.shimeji's branch in to kick off 7.x-2.x development.

kleve’s picture

kleve commented

It would have been nice to get some credit as a commiter for this issue...

haiiro.shimeji’s picture

haiiro.shimeji commented

Is this patch also effective for API v2?
If that is right, I think this should be applied to 7.x-1.x branch.

kleve’s picture

kleve commented

Yes. The patch does not consider any API version, it only makes the API field optional to use.

haiiro.shimeji’s picture

haiiro.shimeji commented
Version: 7.x-2.x-dev » 7.x-1.x-dev

Ok, I pick the commit and apply that to 7.x-1.x.
I reverted the Version to 7.x-1.x-dev, because this issue is originally for using API ver2 without API key.

Thanks a lot!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.