Firstly thanks for this module it is exactly what I need.

I upgraded to your new release today and have encountered a few problems with layout. At /drupalsite/mysite/8/edit/layout the list of available layouts shows the selector button in the right spot , to the left of the image, on the first layout but for subsequent layouts it's in the middle of the screen, underneath the text.

Also the first time that a user goes to mysite he gets a warning error

warning: Invalid argument supplied for foreach() in /home/tu/tun/tuneup.com.au/public/www/drupal/modules/mysite/plugins/layouts/default.php on line 27.

It doesn't stop me using it and in Safari I can still select different layouts, the button sticks out over the text enough to select it, doesn't with Firefox. Once the user configures their mysite the message goes away.

I ran the update script, deleted the red and blue styles, am getting some other errors with mysite icons so I've disabled it for now, can sort it later.

running Drupal 5.1 PHP4, MySQL 5.0 Mac OSX 10.3.9

CommentFileSizeAuthor
#11 Immagine 9.png378.24 KBjofaglia
#3 Picture 1_41.png76.57 KBagentrickard

Comments

agentrickard’s picture

Most of these sound like CSS issues, which I cannot verify. Screenshots would help. Patches would be better. Safari is notorious for quirky CSS.

As for the warning:

warning: Invalid argument supplied for foreach() in /home/tu/tun/tuneup.com.au/public/www/drupal/modules/mysite/plugins/layouts/default.php on line 27.

I cannot replicate this error. Do you mean a logged-in user who has not created a MySite page? An anonymous user?

Try configuring the Default Content options. Put some content in for users by default and the problem should go away.

agentrickard’s picture

You did replace the old layout files when you upgraded, right? I assume so.

Please open a separate report for MySite Icons, as no one reported any bugs during the beta.

agentrickard’s picture

StatusFileSize
new76.57 KB

Attached: screenshot of MySite page with Default Content for an anonymous user using the default layout.

PHP 5.1.6 MySQL 4.1.13 running Apache 1.3.x on Mac OS 10.4.9

the fatman’s picture

Title: problem with latout in the new release » problem with layout in the new release

Thanks Ken

Firstly I uploaded the entire mysite folder, including the plugins to the drupal/modules directory when I installed it so the layout plugins will be the new ones.
I added some default content and the warning message is no longer. Am still getting the buttons on the wrong place, I'll investigate the CSS tomorrow.
Having a few other problems with it. Will add a separate report later if I can't sort them out.

Cheers

agentrickard’s picture

If you have to change anything other than module settings, please file an issue.

agentrickard’s picture

Status: Active » Postponed (maintainer needs more info)

It is possible that you are having MySQL 5 issues with MySite Icons. If you can verify, please let me know, as I only test against MySQL 4.

the fatman’s picture

I changed my theme and everything works fine. I was using Pleroma, and had made a few changes to the css, that may have been it. Switched to zen now which I prefer anyway. Sorted the other stuff out although still not on top of mysite icons, will keep going with it.

Thanks for this module, it's awesome, and thanks for your patience and quick replies.

Cheers

agentrickard’s picture

Status: Postponed (maintainer needs more info) » Closed (won't fix)

There were three issues here:

1) CSS

I'm going to call this as a "known" issue with certain contributed themes. Not sure that there is much I can do about this. I know that fixed-width themes can cause some layout issues.

2) empty array

This is either a configuration issue (you didn't set the defaults up) or a logic error in one of the theme_help functions. Calling it "configuration" since setting defaults made it go away.

3) icons

Will address MySite Icons at http://drupal.org/node/150919.

jofaglia’s picture

Version: 5.x-2.0 » 5.x-2.12

Just wanted to share a workaround for
"list of available layouts shows the selector button in the right spot, to the left of the image, on the first layout but for subsequent layouts it's in the middle of the screen, underneath the text",
I observed this issue on contributed theme "aquasoft"
(as far as I understand this is marked as a CSS issue 1)

The problem was visible both with CSS v 1.21 and current CSS mysite.css,v 1.22 (this is Mysite 5.x-2.12's CSS)

Workaround consists in adding a non breakable space between the radio button and the image and text block, on each row. In mysite.module the block of code preceeded by comment "// layout settings" is basically a for loop which loops on available layouts and outputs an html line of code. Add the nbsp:
$options[$value] = '&nbsp<div class="mysite-layout-image">......'
refresh the page, the radio buttons now stay on left and images and text on the right of each row.

Drupal 5.2
GD library bundled (2.0.28 compatible)
JQuery Update Installed correctly
The current installed version of JQuery is 1.1.2
MySQL database 4.1.20
PHP 4.3.9
Unicode library PHP Mbstring Extension
Web server Apache/2.0.52 (Red Hat)

agentrickard’s picture

Title: problem with layout in the new release » CSS for layout selection
Version: 5.x-2.12 » 5.x-2.13
Status: Closed (won't fix) » Active

Interesting.

I'd really like to see this fixed without the &nbsp;. That seems very inelegant.

This was a Safari issue? Mac or PC?

jofaglia’s picture

StatusFileSize
new378.24 KB

I think you can reproduce it, just install the aquasoft theme among your themes

http://ftp.drupal.org/files/projects/aquasoft-5.x-1.0.tar.gz

then activate it as you know (!) and finally go to the content layout configure page for you own mysite.

Should appear as described in this thread, and as visible in the attached screenshot.

This screenshot is taken from a mac. I have just installed the aquasoft theme for this very test. As you can see my browser here is firefox, server is as described above; I have just tested with safari, same behaviour. But I lived with this issue for a couple of weeks before taking out a hammer from my toolbox, with mac and pc clients on different installations (redhat and windoz), with IE and firefox, and I never could see it wright, until as said I took out a hammer and banged the nbsp in as I told. I tried with opera right now for the first time, it is better but definitely not as you designed it---neither before, nor after the nbsp. Many thanks.

agentrickard’s picture

Fix:

The correct fix occurred to me last night: theme the form into a table.

I'll just work on that solution, which will make the css issue go away.

agentrickard’s picture

I have this working and should commit the change shortly.

agentrickard’s picture

Status: Active » Fixed

Committed to 5-2 branch and HEAD. Thanks for sticking with this one.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

MatBoy’s picture

I have the same issue with the latest version of all modules that are installed

warning: Invalid argument supplied for foreach() in /var/www/html/drupal/modules/mysite/plugins/layouts/default.php on line 29.

What would be the fix for the moment ?

agentrickard’s picture

Configure default content for the module.