For consistency with single-valued fields, the colon in the label for multi-valued field forms should be removed.

Comments

C. Lee’s picture

Status: Active » Needs review
StatusFileSize
new1.18 KB
C. Lee’s picture

Category: feature » task
C. Lee’s picture

StatusFileSize
new648 bytes

Sorry, the previous patch contained a patch for another issue; here is the correct patch.

Status: Needs review » Needs work

The last submitted patch, remove-colon-1507556-3.patch, failed testing.

C. Lee’s picture

Status: Needs work » Needs review
C. Lee’s picture

#3: remove-colon-1507556-3.patch queued for re-testing.

dcam’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Novice, +Needs backport to D7
StatusFileSize
new14.75 KB
new15.43 KB

#3 still applies and correctly removes the colon following multi-valued field titles. See the attached before and after images.

This issue exists in D7 and should be backported.

amit.drupal’s picture

use hook_form_alter for remove colon from label
function custom_form_alter(&$form, &$form_state) {
if($form_id == 'form_name')
{
unset($form['title']['#title']);
}
}

swentel’s picture

Backport is probably not going to happen as it's changing a string. It's fine for me though for Drupal 8.

dries’s picture

Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to 8.x. Moving to 7.x Thanks!

ishadakota’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new628 bytes

Patch against 7.x

jfhovinne’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new10.73 KB
new10.82 KB

#11 applies and correctly removes the semicolon in 7.x-dev, see attached screenshots.

prashant.c’s picture

You can try this in hook_form_alter() function
if (($form_id == 'page_node_form')) {
// Change title to Name
//print_r($form['title']['#title']);
$form['title']['#title']='';
$form['title']['#title'] = t('Name');

}

webchick’s picture

Category: task » bug
Status: Reviewed & tested by the community » Fixed

Hm. While I guess it's conceivable that this could break translations, that looks like a string unlikely to be translated. And it's a legit bug fix, since this is inconsistent with all other fields.

Committed and pushed to 7.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

David_Rothstein’s picture

Issue tags: +7.17 release notes

Agreed that's pretty unlikely to break actual translations, but it can't hurt to add it to the release notes and CHANGELOG.txt just in case.